#863 closed task (done)
HeuristicLab 3.3.0 code review
| Reported by: | gkronber | Owned by: | swagner |
|---|---|---|---|
| Priority: | highest | Milestone: | HeuristicLab 3.3.0 |
| Component: | General | Version: | 3.3 |
| Keywords: | Cc: |
Description (last modified by swagner)
This ticket tracks efforts of the code review of all components related to HeuristicLab 3.3.0.
All review comments should be published on the wiki pages of the HeuristicLab 3.3.0 Code Review.
Attachments (2)
Change History (22)
Changed 14 years ago by gkronber
comment:1 Changed 14 years ago by gkronber
PluginInfrastructure: PluginBase and ApplicationBase should be renamed to Plugin and Application.
comment:2 Changed 14 years ago by gkronber
Fixed issues in plugin infrastructure as identified by abeham with r2748.
comment:3 Changed 14 years ago by swagner
- Component changed from ### Undefined ### to General
- Priority changed from major to blocker
- Status changed from new to assigned
- Summary changed from Code review to HeuristicLab 3.3 Code review
- Version changed from 3.2 to 3.3
comment:4 Changed 14 years ago by swagner
- Status changed from assigned to new
comment:5 Changed 14 years ago by swagner
- Description modified (diff)
Changed 14 years ago by abeham
comment:6 follow-up: ↓ 7 Changed 14 years ago by abeham
I added my final version including some static code analysis charts generated with SourceMonitor. I also updated the Code Issues section, one remark I had about sanity checks in PluginAttribute proved to be unnecessary when I looked into PluginValidator. A plugin with empty name is discarded there already, the exception in the constructor will not fire. Still for consistency, I think it's okay.
comment:7 in reply to: ↑ 6 Changed 14 years ago by gkronber
Replying to abeham:
I added my final version including some static code analysis charts generated with SourceMonitor. I also updated the Code Issues section, one remark I had about sanity checks in PluginAttribute proved to be unnecessary when I looked into PluginValidator. A plugin with empty name is discarded there already, the exception in the constructor will not fire. Still for consistency, I think it's okay.
Implemented changes as suggested by abeham after code review and simplified method PluginValidator.GetPluginDescription() with r2763.
comment:8 Changed 14 years ago by swagner
- Description modified (diff)
comment:9 Changed 14 years ago by gkronber
Added a way to store information why a plugin is disabled in plugin descriptions as suggested by abeham with r2779.
comment:10 Changed 14 years ago by swagner
- Summary changed from HeuristicLab 3.3 Code review to HeuristicLab 3.3.0 code review
comment:11 Changed 14 years ago by swagner
- Description modified (diff)
comment:12 Changed 14 years ago by swagner
- Description modified (diff)
comment:13 Changed 14 years ago by swagner
- Status changed from new to assigned
comment:14 Changed 14 years ago by swagner
Implemented reviewers' comments in r3287.
comment:15 Changed 14 years ago by swagner
Renamed Engine.ProcessNextOperator into Engine.ProcessNextOperation in r3288.
comment:16 Changed 14 years ago by swagner
Removed unnecessary plugin HeuristicLab.Algorithms.GeneticAlgorithm.Views in r3363.
comment:17 Changed 14 years ago by swagner
Adapted item names of generic items to reflect the type of their generic parameters in r3822.
comment:18 Changed 14 years ago by swagner
- Resolution set to fixed
- Status changed from assigned to closed
The reviewing phase of HeuristicLab 3.3.0 has ended with the release of version 3.3.0. Remaining issues should be treated in more specific tickets.
comment:19 Changed 14 years ago by swagner
- Milestone changed from Iteration 4 to Current
Milestone Iteration 4 deleted
comment:11 Changed 14 years ago by swagner
- Milestone changed from Current to HeuristicLab 3.3.0
Milestone Current deleted
Code review PluginInfrastructure abeham 2010-02-02