Opened 12 months ago

Closed 9 months ago

#3005 closed feature request (done)

There should be an option to make ValueParameters read only

Reported by: mkommend Owned by: abeham
Priority: medium Milestone: HeuristicLab 3.3.16
Component: Parameters Version: trunk
Keywords: Cc:

Description

Especially in base classes the use of parameters is not clear upfront. However, in subclasses (e.g. concrete problem implementations) the value of a parameter should never be deleted / overriden. Therefore, a ready only flag which prevents modification of the parameter value per code and in the GUI should be introduced.

Change History (13)

comment:1 Changed 12 months ago by mkommend

  • Status changed from new to accepted

comment:2 Changed 12 months ago by mkommend

r16872: Added readonly flag to all value parameters.

comment:3 Changed 12 months ago by mkommend

r16873: Adapted genetic programming problems to disallow modifications of the grammar.
r16875: Removed parameter ctors with getsCollected flag.

comment:4 Changed 12 months ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from accepted to reviewing

comment:5 Changed 12 months ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from reviewing to readytorelease

Reviewed r16872

Setting the readonly parameter to true after assigning a grammar in UpdateGrammar may override that a user of that class has previously set it to false.

comment:6 Changed 11 months ago by mkommend

r16877: Adapted FLA to the changed parameter ctors.

comment:7 Changed 11 months ago by bburlacu

r16890: Add null check to prevent exception in ConstrainedValueParameterView

comment:8 Changed 11 months ago by gkronber

ad r16877: visual studio auto-format settings problem

comment:9 Changed 11 months ago by abeham

r16916: reverted formatting changes of EngineAlgorithmOperator and added .editorconfig file to solution

comment:10 Changed 9 months ago by mkommend

  • Keywords depends-2520 added

comment:11 Changed 9 months ago by abeham

  • Keywords depends-2520 removed
  • Owner changed from mkommend to abeham
  • Status changed from readytorelease to reviewing

Still need review for: r16873, r16875, r16890

comment:12 Changed 9 months ago by abeham

  • Status changed from reviewing to readytorelease

Reviewed the remaining changes (16873, 16875, 16890). My comment above was actually targeted at the changes in r16873.

comment:13 Changed 9 months ago by abeham

  • Resolution set to done
  • Status changed from readytorelease to closed

r17149: merged to stable (16872, 16873, 16875, 16890)

Note: See TracTickets for help on using tickets.