Opened 5 months ago

Last modified 3 weeks ago

#2965 readytorelease feature request

Cancelable Save (to File) Command

Reported by: pfleck Owned by: jkarder
Priority: medium Milestone: HeuristicLab 3.3.16
Component: Persistence Version: trunk
Keywords: Cc:

Description (last modified by pfleck)

After the improvements in #2845, we should make the "Save Item"-progress cancelable. This is especially helpful for large files when someone accidentally pressed Ctrl+S.

However, we first need a way to cancel the serialization progress, therefore the persistence has to be slightly adapted, by passing a CancellationToken into the corresponding methods.

This ticket has to be released after #2845.

Attachments (1)

CancelableSaveFile.patch (20.6 KB) - added by pfleck 5 months ago.

Download all attachments as: .zip

Change History (9)

Changed 5 months ago by pfleck

comment:1 Changed 5 months ago by pfleck

  • Status changed from new to accepted
  • Version set to branch

r16321 branched trunk

comment:2 Changed 5 months ago by pfleck

r16325

  • Added CancelationTokens for the Save and Serialize methods.
  • Fixed a potential temp-file-leak when replacing the old file with the new one after serialization.

comment:3 Changed 4 months ago by pfleck

r16433 Merged recent trunk changes. Enabled the prepared hooks that allows to cancel the save file using the recently introduced cancelable progressbars (in FileManager).

comment:4 Changed 4 months ago by pfleck

  • Owner changed from pfleck to mkommend
  • Status changed from accepted to reviewing

r16439: Merged trunk changes into branch.

comment:5 Changed 4 months ago by pfleck

  • Version changed from branch to trunk

r16440 merged branch to trunk

comment:6 Changed 4 months ago by pfleck

  • Description modified (diff)

comment:7 Changed 3 weeks ago by mkommend

Reviewed r16321, r16325, r16433, r16439, r16440.

comment:8 Changed 3 weeks ago by jkarder

  • Owner changed from mkommend to jkarder
  • Status changed from reviewing to readytorelease
Note: See TracTickets for help on using tickets.