Opened 17 months ago

Closed 9 months ago

Last modified 9 months ago

#2965 closed feature request (done)

Cancelable Save (to File) Command

Reported by: pfleck Owned by: jkarder
Priority: medium Milestone: HeuristicLab 3.3.16
Component: Persistence Version: trunk
Keywords: merged Cc:

Description (last modified by pfleck)

After the improvements in #2845, we should make the "Save Item"-progress cancelable. This is especially helpful for large files when someone accidentally pressed Ctrl+S.

However, we first need a way to cancel the serialization progress, therefore the persistence has to be slightly adapted, by passing a CancellationToken into the corresponding methods.

This ticket has to be released after #2845.

Attachments (1)

CancelableSaveFile.patch (20.6 KB) - added by pfleck 17 months ago.

Download all attachments as: .zip

Change History (14)

Changed 17 months ago by pfleck

comment:1 Changed 17 months ago by pfleck

  • Status changed from new to accepted
  • Version set to branch

r16321 branched trunk

comment:2 Changed 17 months ago by pfleck

r16325

  • Added CancelationTokens for the Save and Serialize methods.
  • Fixed a potential temp-file-leak when replacing the old file with the new one after serialization.

comment:3 Changed 16 months ago by pfleck

r16433 Merged recent trunk changes. Enabled the prepared hooks that allows to cancel the save file using the recently introduced cancelable progressbars (in FileManager).

comment:4 Changed 16 months ago by pfleck

  • Owner changed from pfleck to mkommend
  • Status changed from accepted to reviewing

r16439: Merged trunk changes into branch.

comment:5 Changed 16 months ago by pfleck

  • Version changed from branch to trunk

r16440 merged branch to trunk

comment:6 Changed 15 months ago by pfleck

  • Description modified (diff)

comment:7 Changed 12 months ago by mkommend

Reviewed r16321, r16325, r16433, r16439, r16440.

comment:8 Changed 12 months ago by jkarder

  • Owner changed from mkommend to jkarder
  • Status changed from reviewing to readytorelease

comment:9 Changed 11 months ago by jkarder

  • Keywords depends-2845 added

comment:10 Changed 11 months ago by pfleck

r16931 removed branch

comment:11 Changed 9 months ago by mkommend

  • Keywords merged added; depends-2845 removed

r17068: Merged r16440 into stable.

comment:12 Changed 9 months ago by abeham

  • Resolution set to done
  • Status changed from readytorelease to closed

comment:13 Changed 9 months ago by gkronber

r17162: add info that r16496 has been merged from trunk to stable (in r16580)

Note: See TracTickets for help on using tickets.