Enhance Progress(View)

[pfleck]

The progress should explicitly differ between "progress" and "endless/marquee" instead of depending on the ProgressValue. Currently, ProgressValue <= 0 or > 1 is is interpreted as "endless" and shown as marquee. Instead we should explicitly differ between those two options and invalid operations should throw an exception (e.g. setting progress value of an "endless" progress). (Currently it is not possible to set an empty progress bar with ProgressValue 0)

Furthermore, the IProgress suggest a Cancel option; however, this does not work currently.

This ticket will be released together with #2839.

[pfleck]

r15405: Branched trunk

[pfleck]

r15415

• Fixed/Added Progress Cancellation/Stopping
• Added Visible property to progress and ProgressBarMode.

[pfleck]

r15417 Removed Visible property and hide on "Finished".

[pfleck]

r15444 Cancel the artificial delay if progress is stopped.

[pfleck]

r15445: Removed progressbar state (green/orange/red).

[pfleck]

r15446:

• Start progres with initial progress value in several cases to use the progress value update.
• Removed object disposal guard in ProgressView because it can block part of the initialization.

[pfleck]

r15477

• Added an explicit method for StartMarquee.
• Renamed Add/RemoveOperationProgress methods.
• Moved progress helpers from MainForm into static Progress methods named Show and Hide.

[pfleck]

r15852 renamed branch folder

[pfleck]

r16307 Merged trunk changes before source move into branch

[pfleck]

r16308 reverted the last merge (r16307) because some revisions were missing

[pfleck]

r16311 Merged trunk changes into branch (15406-15681, 15683-16308)

[pfleck]

r16312 Adapted new Hive-Project-Management and RegressionSolutionVariableImpactsView to Progress updates.

[pfleck]

r16314 Moved the entire progress API to the Progress class and made the progress API within the MainForm internal.

[pfleck]

r16317 Combined separate Show methods into single one with enum parameter specifying the ProgressMode. Renamed Continuous and Marquee to Determinate and Indeterminate.

[pfleck]

r16318 Add optional stop and cancel handler to the Show helpers. Replaced the AddProgressTo... and RemoveProgressFrom... methods with the existing Show and Hide methods.

[pfleck]

r16319 merged latest trunk changes

[pfleck]

I tried to merge back into trunk but it didn't go as expected.

r15406:15851 (before the branch-rename)
r15853:16318 (after the branch-rename)

Merging those two ranges does not work properly since the "big merge" from the trunk into the branch (which contained the trunk/sources rename) happened in the second revision-range (r16307). Thus, merging the first revision range into the trunk would require redoing that merge again.

Alternatively, I tried to merge all recent trunk changes into the branch and then make a "fast-forward" by merging from two different tree using the trunk as "from" and branch as "to" (as described in [0] at "Merging Two Different Trees"). In this scenario, the merge went fine (no conflicts), however, it seems that all the merge info got moved from the individual plugin folders into the trunk folder.

[0] ​https://tortoisesvn.net/docs/release/TortoiseSVN_en/tsvn-dug-merge.html

[pfleck]

r16428: Merged recent trunk changes into branch

[pfleck]

r16430 merged branch into trunk
Reviewed by mkommenda

This commit also contains a lot of merge info moves from the individual folder onto the trunk.

[jkarder]

r16447: adapted BioBoost addon

[pfleck]

r16511 Temporarily removed null check to avoid the permanently disabled project selector in Hive.

The issue of this is caused because a Progress should be shown on a Dialog. Since a Dialog has no Parent Control, the re-enabling after removing the ProgressView does not work. Furthermore, the ProgressView is actually never shown since there is no Parent Control where the ProgressView can be attached to.

[pfleck]

r16512

• Re-enabled null-check and added exception when showing Progress on control with no parent (Forms and Dialogs).
• Adapted Progress in HiveResourceSelectorDialog to show the dialog on the selector-View and not on the dialog itself.

related to comment:115:ticket:2839

[pfleck]

r16923 removed branch

[pfleck]

There is still a bug if an exception occurs while a progressbar is shown.

[pfleck]

I wasn't able to reproduce any bug in relation with exceptions occurring while an active progress. It might be the case that a progress wasn't removed in case of an exception.

I attached a patch that surrounds some cases with a try-finally-block to ensure the progress is removed in any circumstance. However, I am not sure if we should really apply the patch since I could not reproduce any errors.

[mkommend]

Replying to pfleck:

I wasn't able to reproduce any bug in relation with exceptions occurring while an active progress. It might be the case that a progress wasn't removed in case of an exception.

I attached a patch that surrounds some cases with a try-finally-block to ensure the progress is removed in any circumstance. However, I am not sure if we should really apply the patch since I could not reproduce any errors.

After a short discussion it has been decided that this patch will no be applied.

[mkommend]

r17062: Merged 16430 into stable.
r17064: Merged 16447, 16511, 16512 into stable.