Opened 18 months ago

Closed 9 months ago

Last modified 8 months ago

#2955 closed enhancement (done)

Improve evaluating models on new data

Reported by: mkommend Owned by: mkommend
Priority: high Milestone: HeuristicLab 3.3.16
Component: Problems.DataAnalysis Version: trunk
Keywords: Cc:

Description

Currently, it is only possible to evaluate a model on new data if the different problem data exactly matches the original one w.r.t variable names. Even unused variables that do not occur in the model (either because of feature selection or disabling them in the problem data) are compared and have to have exact same spelling. This is a relic from the evolving source code, because previously there was no way to determine which variables are used in a model (input and target). Due to the inclusion of variable information in the models (#2604) it becomes feasible to refactor this functionality and only check for actually used variables when applying it on new data.

Change History (12)

comment:1 Changed 18 months ago by mkommend

  • Status changed from new to accepted

comment:2 Changed 18 months ago by mkommend

r16241: Added utility method that checks if a variable is present in the dataset.

comment:3 Changed 18 months ago by mkommend

r16243: Added IsProblemDataCompatible and IsDatasetCompatible to all DataAnalysisModels.

comment:4 Changed 18 months ago by mkommend

r16244: Used IsProblemDataCompatible and IsDatasetCompatible instead of now obsolete AdjustProblemDataProperties when exchanging the problem data of data analysis solutions.

Last edited 18 months ago by mkommend (previous) (diff)

comment:5 Changed 18 months ago by mkommend

  • Owner changed from mkommend to gkronber
  • Status changed from accepted to reviewing

comment:6 Changed 12 months ago by gkronber

  • Status changed from reviewing to readytorelease

Reviewed r16241, r16243, r16244 and tested in HL.

comment:7 follow-up: Changed 12 months ago by gkronber

r16763: changed error strings when trying to load an incompatible dataset for a model.

comment:8 in reply to: ↑ 7 Changed 12 months ago by mkommend

Replying to gkronber:

r16763: changed error strings when trying to load an incompatible dataset for a model.

Thank you for improving the error message.

comment:9 Changed 9 months ago by mkommend

  • Owner changed from gkronber to mkommend
  • Status changed from readytorelease to assigned

comment:10 Changed 9 months ago by mkommend

  • Status changed from assigned to readytorelease

comment:11 Changed 9 months ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed

r17054: Merged r16241, r16243, r16244, r16763 into stable.

comment:12 Changed 8 months ago by gkronber

r17172: update mergeinfo

Note: See TracTickets for help on using tickets.