Changeset 16512

Timestamp:

01/07/19 14:55:34 (6 years ago)

Author:

pfleck

Message:

#2845

• Re-enabled null-check and added exception when showing Progress on control with no parent (Forms and Dialogs).
• Adapted Progress in HiveResourceSelectorDialog to show the dialog on the selector-View and not on the dialog itself.

Location:

trunk

Files:

• HeuristicLab.Clients.Hive.JobManager/3.3/Views/HiveResourceSelectorDialog.cs (modified) (2 diffs)
• HeuristicLab.MainForm.WindowsForms/3.3/Controls/ProgressView.cs (modified) (2 diffs)

trunk/HeuristicLab.Clients.Hive.JobManager/3.3/Views/HiveResourceSelectorDialog.cs

@@ -96 +96 @@
       if (InvokeRequired) Invoke((Action<object, EventArgs>)HiveClient_Instance_Refreshing, sender, e);
       else {
-        Progress.ShowOnControl(this, "Refreshing", ProgressMode.Indeterminate);
         refreshButton.Enabled = false;
+        okButton.Enabled = false;
+        cancelButton.Enabled = false;
+        // Progress cannot be shown on dialog (no parent control), thus it is shown on the selector
+        Progress.Show(hiveResourceSelector, "Refreshing", ProgressMode.Indeterminate);
       }
     }
@@ -104 +107 @@
       if (InvokeRequired) Invoke((Action<object, EventArgs>)HiveClient_Instance_Refreshed, sender, e);
       else {
-        Progress.HideFromControl(this);
+        Progress.Hide(hiveResourceSelector);
+        okButton.Enabled = true;
+        cancelButton.Enabled = true;
         refreshButton.Enabled = true;
       }

trunk/HeuristicLab.MainForm.WindowsForms/3.3/Controls/ProgressView.cs

@@ -38 +38 @@
       : base() {
       if (control == null) throw new ArgumentNullException("control");
+      if (control.Parent == null) throw new InvalidOperationException("A Progress can only be shown on controls that have a Parent-control. Therefore, Dialogs and Forms cannot have an associated ProgressView.");
       if (content == null) throw new ArgumentNullException("content");
       InitializeComponent();
@@ -127 +128 @@
         return;
       }
-      //if (Parent == null) return;
+      if (Parent == null) return;
 
       Visible = false;