Changeset 16512


Ignore:
Timestamp:
01/07/19 14:55:34 (6 months ago)
Author:
pfleck
Message:

#2845

  • Re-enabled null-check and added exception when showing Progress on control with no parent (Forms and Dialogs).
  • Adapted Progress in HiveResourceSelectorDialog to show the dialog on the selector-View and not on the dialog itself.
Location:
trunk
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/HeuristicLab.Clients.Hive.JobManager/3.3/Views/HiveResourceSelectorDialog.cs

    r16430 r16512  
    9696      if (InvokeRequired) Invoke((Action<object, EventArgs>)HiveClient_Instance_Refreshing, sender, e);
    9797      else {
    98         Progress.ShowOnControl(this, "Refreshing", ProgressMode.Indeterminate);
    9998        refreshButton.Enabled = false;
     99        okButton.Enabled = false;
     100        cancelButton.Enabled = false;
     101        // Progress cannot be shown on dialog (no parent control), thus it is shown on the selector
     102        Progress.Show(hiveResourceSelector, "Refreshing", ProgressMode.Indeterminate);
    100103      }
    101104    }
     
    104107      if (InvokeRequired) Invoke((Action<object, EventArgs>)HiveClient_Instance_Refreshed, sender, e);
    105108      else {
    106         Progress.HideFromControl(this);
     109        Progress.Hide(hiveResourceSelector);
     110        okButton.Enabled = true;
     111        cancelButton.Enabled = true;
    107112        refreshButton.Enabled = true;
    108113      }
  • trunk/HeuristicLab.MainForm.WindowsForms/3.3/Controls/ProgressView.cs

    r16511 r16512  
    3838      : base() {
    3939      if (control == null) throw new ArgumentNullException("control");
     40      if (control.Parent == null) throw new InvalidOperationException("A Progress can only be shown on controls that have a Parent-control. Therefore, Dialogs and Forms cannot have an associated ProgressView.");
    4041      if (content == null) throw new ArgumentNullException("content");
    4142      InitializeComponent();
     
    127128        return;
    128129      }
    129       //if (Parent == null) return;
     130      if (Parent == null) return;
    130131
    131132      Visible = false;
Note: See TracChangeset for help on using the changeset viewer.