RunLengthDistributionView shows incorrect values for runs in which the target is reached in the last generation

[gkronber]

Because of the logic for determining the number of active runs (movingTargets) the y-value of the last point is calculated incorrectly when there are hits in the final generation.

Critical lines of code (line 436):

            missedecdf += iter.Current.Value;
            movingTargets -= iter.Current.Value;
            if (row.Points.Count > 0 && row.Points.Last().XValue == iter.Current.Key) {
              row.Points.Last().SetValueY(ecdf / movingTargets);
              row.Points.Last().Color = Color.FromArgb(255 - (int)Math.Floor(255 * (prevmissedecdf / totalTargets)), colors[colorCount]);
            } else {
              var dp = new DataPoint(iter.Current.Key, ecdf / movingTargets) {
                Color = Color.FromArgb(255 - (int)Math.Floor(255 * (prevmissedecdf / totalTargets)), colors[colorCount])
            };

and (line 469):

          ecdf += h.Value;
          if (row.Points.Count > 0 && row.Points.Last().XValue == h.Key) {
            row.Points.Last().SetValueY(ecdf / movingTargets);
            row.Points.Last().Color = Color.FromArgb(255 - (int)Math.Floor(255 * (missedecdf / totalTargets)), colors[colorCount]);
          } 

[gkronber]

Steps to reproduce:

1. Load attached file RLDV Test.hl
2. Open "Run Length Distribution View"
3. Set target to 0.98 (absolute) --> correct
4. Set target to 0.99 (absolute) --> incorrect

[abeham]

r16716:

• Added a lof changes from #1614 branch not yet merged to trunk
• Fixed problem with missed targets at simultaneous points to hits

I think this should fix your problems. The view still needs some refactoring. The base case (ecdf by total targets) would be much easier to compute. The moving targets case is rather cumbersome.

[gkronber]

r16795: reverted unintended changes of tabPage properties (BackgroundColor and VisualStyles) from r16716

[gkronber]

Reviewed r16716 and tested the view again with the attached file. I did not find any more problems.

[gkronber]

r16836: merged r16716 and r16795 from trunk to stable