Opened 3 months ago

Last modified 3 months ago

#2947 assigned enhancement

Configure Dialog for IndexedDataTableView

Reported by: pfleck Owned by: pfleck
Priority: medium Milestone: HeuristicLab 3.3.16
Component: Analysis.Views Version: branch
Keywords: Cc:

Description

The IndexedDataTableView is missing some features that are implemented in the DatatTableView and in the ScatterPlotView.

  • Configuring the Charts with a VisualPropertiesDialog
    • Implementing IConfigureableView` for opening the dialog
    • ContextMenuItem for opening the same dialog
  • Hiding the Name-TextBox
    • The corresponding properties of the DataTable- and ScatterPlotView should be named consisted (currently ShowChartOnly and ShowName).

Change History (6)

comment:1 Changed 3 months ago by pfleck

  • Status changed from new to accepted
  • Version set to branch

r16148 branched trunk

comment:2 Changed 3 months ago by pfleck

r16149

  • Added interfaces for DataRow and DataTable (IDataTable is generic because the NamedItemCollection is invariant)
  • Adapted DataTableVisualPropertiesDialog to use the new interfaces
  • Added IConfigurableView to IndexedDataTableView
  • Fixed VisualProperty.Title change in IndexedDataTableView

comment:3 Changed 3 months ago by pfleck

r16150

  • Added context menu to open the VisualProperties dialog for the IndexedDataTableView.
  • Changed the StatterPlotView.ShowName into ShowChartOnly to match the property names of the (Indexed)DataTableView.
Last edited 3 months ago by pfleck (previous) (diff)

comment:4 Changed 3 months ago by pfleck

r16156 fixed initial title for IndexedDataTable

comment:5 Changed 3 months ago by pfleck

  • Owner changed from pfleck to abeham
  • Status changed from accepted to reviewing

Maybe we can come up with a version that does not need the generic IDataTable, however, I don't think this should be a big deal because the interface previously did not existed anyway.

In the long run (HL 4.0, maybe), we could also consider merging DataTable, IndexedDataTable and ScatterPlot into a single DataTable. Per default, we could assume that the x-value is the index of the data point, and also allow the user to explicitly specify another DataRow as x-axis to offer a similar behavior such as the ScatterPlot and IndexedDataTable currently do.

comment:6 Changed 3 months ago by abeham

  • Owner changed from abeham to pfleck
  • Status changed from reviewing to assigned

"Start at Index 0" is meaningless for IndexedDataRows is there a way to disable it?

Otherwise, the changes look good to me.

Note: See TracTickets for help on using tickets.