Opened 2 years ago

Closed 15 months ago

#2947 closed enhancement (done)

Configure Dialog for IndexedDataTableView

Reported by: pfleck Owned by: pfleck
Priority: medium Milestone: HeuristicLab 3.3.16
Component: Analysis.Views Version: trunk
Keywords: Cc:

Description

The IndexedDataTableView is missing some features that are implemented in the DatatTableView and in the ScatterPlotView.

  • Configuring the Charts with a VisualPropertiesDialog
    • Implementing IConfigureableView` for opening the dialog
    • ContextMenuItem for opening the same dialog
  • Hiding the Name-TextBox
    • The corresponding properties of the DataTable- and ScatterPlotView should be named consisted (currently ShowChartOnly and ShowName).

Change History (15)

comment:1 Changed 23 months ago by pfleck

  • Status changed from new to accepted
  • Version set to branch

r16148 branched trunk

comment:2 Changed 23 months ago by pfleck

r16149

  • Added interfaces for DataRow and DataTable (IDataTable is generic because the NamedItemCollection is invariant)
  • Adapted DataTableVisualPropertiesDialog to use the new interfaces
  • Added IConfigurableView to IndexedDataTableView
  • Fixed VisualProperty.Title change in IndexedDataTableView

comment:3 Changed 23 months ago by pfleck

r16150

  • Added context menu to open the VisualProperties dialog for the IndexedDataTableView.
  • Changed the StatterPlotView.ShowName into ShowChartOnly to match the property names of the (Indexed)DataTableView.
Last edited 23 months ago by pfleck (previous) (diff)

comment:4 Changed 23 months ago by pfleck

r16156 fixed initial title for IndexedDataTable

comment:5 Changed 23 months ago by pfleck

  • Owner changed from pfleck to abeham
  • Status changed from accepted to reviewing

Maybe we can come up with a version that does not need the generic IDataTable, however, I don't think this should be a big deal because the interface previously did not existed anyway.

In the long run (HL 4.0, maybe), we could also consider merging DataTable, IndexedDataTable and ScatterPlot into a single DataTable. Per default, we could assume that the x-value is the index of the data point, and also allow the user to explicitly specify another DataRow as x-axis to offer a similar behavior such as the ScatterPlot and IndexedDataTable currently do.

comment:6 follow-up: Changed 23 months ago by abeham

  • Owner changed from abeham to pfleck
  • Status changed from reviewing to assigned

"Start at Index 0" is meaningless for IndexedDataRows is there a way to disable it?

Otherwise, the changes look good to me.

comment:7 Changed 19 months ago by pfleck

  • Status changed from assigned to accepted

r16520 merged trunk into branch

comment:8 in reply to: ↑ 6 Changed 19 months ago by pfleck

Replying to abeham:

"Start at Index 0" is meaningless for IndexedDataRows is there a way to disable it?

Otherwise, the changes look good to me.

I checked if there are any quick ways to disable the checkbox, but we can't access the (Indexed)DataTable from the VisualProperties to determine whether to disable the "Start at Index 0" or not.

After discussing it with abeham, we will leave it as it currently is, and treat the issue eventually when we unify the ScatterPlot and DataTable.

comment:9 Changed 19 months ago by pfleck

r16524

  • Added backwards compatibility for IndexedDataTable.VisualProperties.Title
  • Removed syncing of ItemName and VisualProperties.Title when (Indexed)DataTable is active.

comment:10 Changed 19 months ago by pfleck

  • Owner changed from pfleck to abeham
  • Status changed from accepted to reviewing

comment:11 Changed 19 months ago by abeham

  • Owner changed from abeham to pfleck
  • Status changed from reviewing to readytorelease

Change r16524 looks good to me. Thanks

comment:12 Changed 19 months ago by pfleck

r16527 merged branch to trunk

comment:13 Changed 19 months ago by pfleck

  • Version changed from branch to trunk

comment:14 Changed 16 months ago by gkronber

r16838: merged r16527 from trunk to stable (without useless mergeinfo properties)

comment:15 Changed 15 months ago by pfleck

  • Resolution set to done
  • Status changed from readytorelease to closed

r16929: removed branch

Note: See TracTickets for help on using tickets.