#2908 closed defect (done)
Make ResourceRegressionInstanceProvider csv functionality useable from another assembly
Reported by: | fbaching | Owned by: | gkronber |
---|---|---|---|
Priority: | medium | Milestone: | HeuristicLab 3.3.16 |
Component: | Problems.Instances | Version: | trunk |
Keywords: | Cc: |
Description
ResourceRegressionInstanceProvider csv functionality cannot be used from another assembly. Needed for easy addition of external InstanceProviders for csv data that cannto be added to the HL-repo.
- Property ResourceName of the class ResourceRegressionDataDescriptor is internal. Must however be supplied.
- ResourceRegressionInstanceProvider's check for access to manifest resources queries for executing assembly instead of caller's-type assembly
Change History (12)
comment:1 Changed 7 years ago by fbaching
- Component changed from ### Undefined ### to Problems.Instances
comment:2 Changed 7 years ago by fbaching
- Status changed from new to accepted
comment:3 Changed 7 years ago by fbaching
- Owner changed from fbaching to gkronber
- Status changed from accepted to reviewing
comment:4 Changed 7 years ago by fbaching
- Owner changed from gkronber to fbaching
- Status changed from reviewing to assigned
changing setter of ResourceRegressionDataDescriptor.ResourceName to private and adding the resource name as a constructor parameter after discussion with mkommend
comment:5 Changed 7 years ago by fbaching
- Owner changed from fbaching to gkronber
- Status changed from assigned to reviewing
r15855: change access level to prevent external changes of value; add constructor parameter for configuration
comment:6 Changed 7 years ago by gkronber
- Owner changed from gkronber to fbaching
- Status changed from reviewing to assigned
Reviewed r15853. Changes are fine.
Concerning r15855: I think the ctors with the resource name as parameter should be removed and replaced by a default ctor. Instead, the resource name should be fixed in each problem instance class.
Reasoning: It is strange that as a caller I have to know the resource name e.g. new Cf1("Cf1.csv"). Instead, it should be possible to just call new Cf1().
comment:7 Changed 6 years ago by gkronber
- Owner changed from fbaching to gkronber
- Status changed from assigned to accepted
comment:8 Changed 6 years ago by gkronber
r16169: changed handling of resource names (moved into data descriptors)
comment:9 Changed 6 years ago by gkronber
- Status changed from accepted to readytorelease
comment:10 Changed 6 years ago by gkronber
comment:11 Changed 6 years ago by gkronber
- Resolution set to done
- Status changed from readytorelease to closed
r15853: Make ResourceRegressionDataDescriptor.ResourceName public to be used in external assembly check for GetType().Assemply instead Assembly.GetExecutingAssembly() to match actual access in line 40 and to make class usable from external assemblies
new JRZ miba RSP cf_stat model will be available in the JRZ Miba git repo