#2885 closed enhancement (done)

Select all with Ctrl+A in RunCollectionView

Reported by: abeham Owned by: abeham
Priority: medium Milestone: HeuristicLab 3.3.16
Component: Optimization.Views Version: trunk
Keywords: Cc:

Description

Selecting all runs, e.g. to copy them in a new run collection is so tedious

Change History (8)

comment:1 Changed 19 months ago by abeham

  • Status changed from new to accepted

comment:2 Changed 19 months ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from accepted to reviewing

r15645: implemented select all

comment:3 Changed 19 months ago by abeham

  • Version set to trunk

comment:4 Changed 19 months ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from reviewing to assigned

Reviewed r15645 and the changes look good.

The only minor concern I have is that for each selected item the selected index changed event is triggered and the according handler executed. However, I have tested it with rather small RunCollections (<50 runs) and there it was not an issue. What do you think about it? Should we deregister the event handler and after the update is finished register it again?

comment:5 Changed 19 months ago by abeham

I tested this with a run collection containing 12,000 runs and did not notice a performance issue. The only effect is that when nothing is selected the first change of Selected to true causes the viewhost to show the item until the second item is selected in which case the viewhost will be blank again. This is very short though. If you think this is undesired I would propose to suppress the selectedindexchanged event handler with a bool property. Changing event handlers could have side effects in case an update was made to the run collection from another thread while select all was in progress.

comment:6 Changed 19 months ago by mkommend

  • Owner changed from abeham to mkommend
  • Status changed from assigned to reviewing

Fine by me.

comment:7 Changed 19 months ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from reviewing to readytorelease

comment:8 Changed 19 months ago by abeham

  • Resolution set to done
  • Status changed from readytorelease to closed

r15717: merged to stable

Note: See TracTickets for help on using tickets.