Context Navigation

#2258 closed enhancement (done)

Executable.Start executes it asynchronously

Reported by:	mkommend	Owned by:	jkarder
Priority:	medium	Milestone:	HeuristicLab 3.3.15
Component:	Optimization	Version:	3.3.10
Keywords:		Cc:

Description

While the name suggests that this method is executed synchronously, it runs in fact asynchronously. Hence, in every script and program code synchronization mechanisms must be used to wait until the executable is finished. It would be better to have a separate way to start the executable in a synchronous way.

The standard in the .NET framework is that asynchronous methods have the postfix async attached to the method name, which would lead to the two methods Start and StartAsync. Though, changing the semantics of Start from asynchronous to synchronous execution would require lots of code changes and break existing script. Maybe, it would be better to add a method StartSync to the executable interface.

Change History (39)

comment:1 Changed 10 years ago by swagner

Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.11
Owner changed from architects to swagner
Status changed from new to assigned

comment:2 Changed 10 years ago by ascheibe

I think we should make this change after switching to .NET4.5 and then add a StartAsync Method which adhears to the TAP. We could maybe then even return Task<ResultCollection>?

Last edited 10 years ago by ascheibe (previous) (diff)

comment:3 Changed 10 years ago by swagner

r11614: Created branch Async

comment:4 Changed 10 years ago by swagner

r11641: Deleted branch Async

comment:5 Changed 10 years ago by swagner

r11642: Created branch Async again in order to include latest changes regarding the switch to .NET 4.5

comment:6 Changed 10 years ago by ascheibe

Milestone changed from HeuristicLab 3.3.11 to HeuristicLab 3.3.12

comment:7 Changed 9 years ago by ascheibe

Milestone changed from HeuristicLab 3.3.12 to HeuristicLab 3.3.13

comment:8 Changed 9 years ago by ascheibe

Milestone changed from HeuristicLab 3.3.13 to HeuristicLab 4.0

comment:9 Changed 9 years ago by jkarder

Owner changed from swagner to jkarder
Status changed from assigned to accepted

comment:10 Changed 9 years ago by jkarder

r13328: deleted branch Async

comment:11 Changed 9 years ago by jkarder

r13329: created branch Async

comment:12 Changed 9 years ago by jkarder

r13349: added StartAsync to IExecutable

comment:13 Changed 9 years ago by jkarder

r13354: improved cancellation support

comment:14 Changed 9 years ago by jkarder

r13355: updated unit test utils

comment:15 Changed 9 years ago by ascheibe

Owner changed from jkarder to ascheibe
Status changed from accepted to reviewing

comment:16 Changed 8 years ago by ascheibe

Owner changed from ascheibe to mkommend

comment:17 Changed 8 years ago by jkarder

Milestone changed from HeuristicLab 4.0 to HeuristicLab 3.3.15
Owner changed from mkommend to abeham

comment:18 Changed 7 years ago by jkarder

Owner changed from abeham to jkarder
Status changed from reviewing to assigned

comment:19 Changed 7 years ago by jkarder

Status changed from assigned to accepted

comment:20 Changed 7 years ago by jkarder

r15065: refactored async methods

synchronously called IExecutables are now executed in the caller's thread
removed old synchronization code from unit tests

comment:21 Changed 7 years ago by jkarder

Owner changed from jkarder to abeham
Status changed from accepted to reviewing

comment:22 Changed 7 years ago by abeham

r15190: fixed starting of cloned algs

comment:23 Changed 7 years ago by abeham

r13349: ok r13354: ok r13355: ok r15065:

Instead of writing await Task.Factory.StartNew((ct) => Start((CancellationToken)ct), cancellationToken, cancellationToken); would it be feasible to write await Task.Run(() => Start(cancellationToken), cancellationToken); ?

The rest seems ok.

comment:24 Changed 7 years ago by jkarder

r15204: worked on execution of cross-validation

comment:25 Changed 7 years ago by mkommend

Tested new changes in CV and still encountered some problems. Frenetically clicking the execution buttons, starts/pauses/stops the CV multiple times which results in strange behavior and brings the GUI out of sync with the content.

Handling of exceptions works fine in my opinion.

The branch has to be updated with the most recent trunk changes.