The VariableStoreView unnecessarily tries to serialize objects.

[bburlacu]

The IsSerializable() method is expensive for large objects, as it needs to serialize the object. Additionally, this method is called every time a variable name is changed (which is not really necessary). A simple fix would be to use a Dictionary<Type, bool> to store this information when a variable is added to avoid calling the serializer when the type is known. I attached a patch to illustrate this quick fix.

[jkarder]

r11437: applied a slightly modified version of bburlacu's patch

[jkarder]

Thanks for the hint. Your code works but does not consider that object graphs can change and that after such changes occur, objects might not be serializable anymore. As this is currently only possible within CSharpScripts themselves, this issue will be ignored for now. Thanks again!

[abeham]

I am also using the variable store in the programmable problem. Does this affect the programmable problem also?

[jkarder]

Replying to abeham:

I am also using the variable store in the programmable problem. Does this affect the programmable problem also?

I will look into it.

[jkarder]

r11439: fixed IsSerializable

[jkarder]

r11472: actually fixed IsSerializable

[mkommend]

Reviewed r11437, r11439, and r11472.

[mkommend]

Must be released in combination with #2262.

[jkarder]

r11907: merged r11437, r11439 and r11472 into stable