Splash screen sometimes causes ObjectDisposedException

[abeham]

Sometimes when one opens the HeuristicLab Starter and one of the applications (dockable for example) an exception is thrown saying that it is tried to access the disposed splash screen object.

This may be difficult to reproduce.

[gkronber]

This has probably been also been fixed together with #138 (r594:596).

I'm still leaving this ticket open for a while. However if the exception doesn't show up anymore it should be closed as 'fixed'.

[gkronber]

No more exceptions since last comment.

[abeham]

Unfortunately I think the bug still exists. I am reopening this and attaching a screenshot.

[gkronber]

The problem is that the SplashScreen is still attached to the Action event of PluginManager when it is already disposed. Two possible causes come to mind:

• The closing event of SplashScreen on which the listener is removed is fired after disposal of SplashScreen.
• There are in fact multiple instances of PluginManager and SplashScreen tries to remove its listener from the incorrect one.

[swagner]

Milestone 3.2 deleted

[gkronber]

Related to #280.

[abeham]

Wrapped the Close() method in SplashScreen to cover in (hopefully) correct sequential order:

# Deregistration of the event listener # Processing of all remaining queued events through Application.DoEvent() # Closing the form

As long as CloseSplashScreen() is called from within !bigLock there should be no problems as it is executed only once. Thinking about it, it might better to perform the lock within CloseSplashScreen() instead of within its caller, but it should work the way it is.

Changes done in r2439

[abeham]

• Readded Application.DoEvents to Manager_Action
• Stopped the fade timer in CloseSplashScreen before closing the form
• Put the lock in UpdateOpacity and CloseSplashScreen

Changes done in r2442

[abeham]

The splash screen still throws an ObjectDisposedException in 3.3, but a different one than in 3.2. I attached a screenshot of the error message. This happened when launching HL 3.3 from visual studio with debugger attached.

[gkronber]

Replying to abeham:

The splash screen still throws an ObjectDisposedException in 3.3, but a different one than in 3.2. I attached a screenshot of the error message. This happened when launching HL 3.3 from visual studio with debugger attached.

Thank you! I will investigate the issue and try to come up with a fix for the next test version.

[gkronber]

Changed starter form to instantiate only one splash screen and show and hide it as required with r3113.

This should eliminate the race-condition problems while disposing the splash screen. Since the single splash screen instance is kept alive over the whole process life time it is also not necessary to manually deregister splash screen methods as event handler for the plugin manager events.

[abeham]

Is this okay with multiple apps starting simultaneously?

[gkronber]

It should be. Since there also was also only one splash screen when starting multiple apps now.

[mkommend]

corrected displaying of the SplashScreen r3241

[gkronber]

Couldn't be reproduced for some time now. Hopefully closing for the last time.

[swagner]

Milestone Iteration 4 deleted

[swagner]

Milestone Current deleted