Opened 8 years ago

Closed 8 years ago

#1487 closed enhancement (done)

Add a serializer for objects of type System.Drawing.Font

Reported by: abeham Owned by: abeham
Priority: medium Milestone: HeuristicLab 3.3.5
Component: Persistence Version: 3.3.5
Keywords: Cc:

Description


Change History (9)

comment:1 Changed 8 years ago by abeham

  • Status changed from new to accepted

comment:2 Changed 8 years ago by abeham

r6020, r6022

  • Added and improved the serializer for Fonts

comment:3 Changed 8 years ago by abeham

  • Owner changed from abeham to epitzer
  • Status changed from accepted to reviewing
  • Version changed from 3.3.3 to branch

comment:4 Changed 8 years ago by epitzer

  • Owner changed from epitzer to abeham

Small improvements to font serialization: (r6027)

  • included font size units and vertical font indicator for complete serialization
  • removed unnecessary checks for null during serialization
  • removed checks during deserializaiton: incorrect files should not cause nulls to be deserialized but throw an error instead
  • added unit test
  • replaced string concatenation with string.Format()

comment:5 Changed 8 years ago by abeham

Thx for the changes! Does the unit test work for you? On my machine it says:

Test method HeuristicLab.Persistence_33.Tests.UseCases.FontTest threw exception: 
System.ArgumentException: Font 'Aharoni' does not support style 'Regular'.

I changed the test in r6028 to use FontFamily.GenericSansSerif instead of FontFamily.Families.First()

Since the ticket is still in reviewing state on your side, please mark it as ready-to-release when you think it's finished.

comment:6 Changed 8 years ago by epitzer

  • Status changed from reviewing to readytorelease

Thanks for the fix. I thinks it is ready.

comment:7 Changed 8 years ago by abeham

  • Milestone changed from HeuristicLab 3.3.4 to HeuristicLab 3.3.5

comment:8 Changed 8 years ago by abeham

r6342

  • merged to trunk

comment:9 Changed 8 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from branch to 3.3.5
Note: See TracTickets for help on using tickets.