Opened 13 years ago
Closed 13 years ago
#1486 closed enhancement (done)
Decouple OperatorGraphVisualizationInfo from the associated view classes
| Reported by: | mkommend | Owned by: | abeham |
|---|---|---|---|
| Priority: | high | Milestone: | HeuristicLab 3.3.4 |
| Component: | Operators.Views.OperatorGraphVisualization | Version: | 3.3.4 |
| Keywords: | Cc: |
Description
This is necessary as Hive 3.4 transports every needed assembly to the executing client. Every OperatorGraph has a IDeepCloneable member visualization info that contains an IGraphVisualizationInfo and therefore an implicit reference from HL.Core to HL.Operators.Views.GraphVisualization and furthermore to HL.MainForm and to the Netron library exists. That highly influences the Hive sandboxing mechanism and must be corrected by extracting the visualization info classes into a separate plugin.
Change History (11)
comment:1 Changed 13 years ago by swagner
comment:2 Changed 13 years ago by mkommend
- Status changed from new to accepted
comment:3 Changed 13 years ago by mkommend
r6036: Decoupled operator graph visualization content classes from view classes.
comment:4 Changed 13 years ago by mkommend
r6037: Deleted unnecessary files.
comment:5 Changed 13 years ago by mkommend
- Owner changed from mkommend to cneumuel
- Status changed from accepted to reviewing
Please test the changes made in r6036 and afterwards forward the ticket to swagner or abeham.
comment:6 Changed 13 years ago by cneumuel
- Owner changed from cneumuel to ascheibe
comment:7 Changed 13 years ago by cneumuel
Plugin.cs.frame in HeuristicLab.Operators.Views.GraphVisualization.Views should be named HeuristicLabOperatorsViewsGraphVisualizationViewsPlugin.cs.frame as it is convention in other plugins.
comment:8 Changed 13 years ago by ascheibe
- Owner changed from ascheibe to swagner
I have tested this with Hive sandboxing and some HeuristicLab sample algorithms. It works, no GUI plugins are pulled in anymore.
comment:9 Changed 13 years ago by abeham
- Owner changed from swagner to abeham
comment:10 Changed 13 years ago by abeham
- Status changed from reviewing to readytorelease
I also made a test with a saved algorithm in 3.3.3 and loaded it in the current trunk, everything works as expected. Thanks!
comment:11 Changed 13 years ago by swagner
- Resolution set to done
- Status changed from readytorelease to closed
- Version changed from 3.3.3 to 3.3.4
In the meantime we used a specific pattern for storing visual properties on the content side for example in DataTable or DataRow. I think we should reuse this pattern also in this case.