Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#1090 closed defect (done)

Problems replace the operators collection after deserialization

Reported by: mkommend Owned by: mkommend
Priority: medium Milestone: HeuristicLab 3.3.1
Component: General Version: 3.3.1
Keywords: Cc: abeham

Description

Most problems have a StorableHook.AfterDeserialization that calls the InitializeOperators method. This method replaces the already loaded operators list with a newly instantiated list and populates the new list. Therefore it is possible that the operators change when an old file is loaded. A more accurate handling of loading problems would be to let the persistence populate the operators and only wire them correctly.

Change History (9)

comment:1 Changed 9 years ago by abeham

  • Owner changed from swagner to abeham
  • Status changed from new to assigned

We fixed this for the algorithms, but seems like we forgot it for the problems.

comment:2 Changed 9 years ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from assigned to new

r4098

  • Fixed initialization of operators and made operator list storable

Reassigning to mkommend for change review

comment:3 Changed 9 years ago by abeham

  • Owner changed from mkommend to abeham

mkommend suggested:

  • Checking the base calls from the storable constructor, that they call the base storable constructor
  • Separate AttachEventHandlers from the post serialization storable hook

comment:4 Changed 9 years ago by abeham

  • Status changed from new to assigned

comment:5 Changed 9 years ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from assigned to new

r4118

  • Fixed problem plugins reloading their operators on deserialization in following problems (forgot on them in the first commit)
    • SupportVectorRegressionProblem
    • SymbolicTimeSeriesPrognosisProblem
  • Fixed a bug in the FeatureSelectionProblem introduced in r4098
  • Fixed the issues mentioned in the code review of mkommend

Reassigning to mkommend for another review please

comment:6 Changed 9 years ago by gkronber

Added a project dependency for the ExternalEvaluation plugin with r4134.

comment:7 Changed 9 years ago by mkommend

  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from 3.3 to 3.3.1

Reviewed the changes by abeham and everything seems to work.

comment:8 Changed 9 years ago by swagner

  • Milestone changed from Iteration 4 to Current

Milestone Iteration 4 deleted

comment:11 Changed 9 years ago by swagner

  • Milestone changed from Current to HeuristicLab 3.3.0

Milestone Current deleted

Note: See TracTickets for help on using tickets.