Changeset 12590 for branches/GBT-trunkintegration/HeuristicLab.Algorithms.DataAnalysis/3.4/GradientBoostedTrees/GradientBoostedTreesAlgorithmStatic.cs

Timestamp:

07/04/15 16:03:36 (9 years ago)

Author:

gkronber

Message:

#2261: preparations for trunk integration (adapt to current trunk version, add license headers, add comments, improve code quality)

File:

• branches/GBT-trunkintegration/HeuristicLab.Algorithms.DataAnalysis/3.4/GradientBoostedTrees/GradientBoostedTreesAlgorithmStatic.cs (modified) (5 diffs)

branches/GBT-trunkintegration/HeuristicLab.Algorithms.DataAnalysis/3.4/GradientBoostedTrees/GradientBoostedTreesAlgorithmStatic.cs

@@ -25 +25 @@
 using System.Diagnostics.Contracts;
 using System.Linq;
-using GradientBoostedTrees;
 using HeuristicLab.Problems.DataAnalysis;
 using HeuristicLab.Random;
@@ -34 +33 @@
 
     public interface IGbmState {
-
       IRegressionModel GetModel();
       double GetTrainLoss();
@@ -42 +40 @@
 
     // created through factory method
+    // GbmState details are private API users can only use methods from IGbmState
     private class GbmState : IGbmState {
       internal IRegressionProblemData problemData { get; set; }
-      internal MersenneTwister random { get; set; }
+      internal MersenneTwister random { get; private set; }
       internal ILossFunction lossFunction { get; set; }
       internal int maxDepth { get; set; }
@@ -50 +49 @@
       internal double r { get; set; }
       internal double m { get; set; }
-      internal RegressionTreeBuilder treeBuilder;
+      internal readonly RegressionTreeBuilder treeBuilder;
 
 
@@ -156 +155 @@
     }
 
-    // allow dynamic adaptation of maxDepth, nu and r
+    // allow dynamic adaptation of maxDepth, nu and r (even though this is not used)
     public static void MakeStep(IGbmState state, int maxDepth, double nu, double r, double m) {
       var gbmState = state as GbmState;