Opened 3 years ago

Closed 3 years ago

#2225 closed defect (done)

VehicleRoutingProblem cannot load TSPLib(CVRP)

Reported by: pfleck Owned by: abeham
Priority: medium Milestone: HeuristicLab 3.3.11
Component: Problems.VehicleRouting Version: 3.3.10
Keywords: Cc:

Description

The VehicleRoutingProblem cannot load the CVRPData from the TSPLIB.

Because the Problem only implements InstanceConsumer of VRPData, but the TSPLIB exports CVRPData, it cannot be loaded.

A patch is attached which adds an InstanceConsumer of CVRPData to the VRP.

Since a CVRPData is as VRPData, a contravariant mechanism of instance consuming would be nice, but I am not sure if this is doable in an easy way.

Attachments (1)

VehicleRoutingProblem.cs.patch (1.3 KB) - added by pfleck 3 years ago.

Download all attachments as: .zip

Change History (13)

Changed 3 years ago by pfleck

comment:1 Changed 3 years ago by pfleck

  • Status changed from new to accepted

comment:2 Changed 3 years ago by pfleck

r11285 The ProblemInstanceProvider is now contravariant. Therefore the ProblemInstanceManager discovers all derivations of InstanceProvider<IVRPData>.

Note that there was a problem with covariant InstanceConsumers with the ProblemInstanceProviderView in the past (#1981). Due to the fixes from #2110 this problem should not occur anymore.

comment:3 Changed 3 years ago by pfleck

r11286 Reverted parts of r10435 since the generic VRPInstanceProvider work accordingly after recent changes.

comment:4 Changed 3 years ago by pfleck

r11287 Fixed unit test for VRP instances.

comment:5 Changed 3 years ago by pfleck

  • Owner changed from pfleck to mkommend
  • Status changed from accepted to reviewing

comment:6 Changed 3 years ago by abeham

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.11

comment:7 Changed 3 years ago by mkommend

  • Owner changed from mkommend to pfleck
  • Status changed from reviewing to assigned

Reviewed r11285, r11286, r11287.

Please check all instance provider names, descriptions and web links, if the provided information is correct(esp. Kytojoki).

Last edited 3 years ago by mkommend (previous) (diff)

comment:8 Changed 3 years ago by pfleck

  • Status changed from assigned to accepted

comment:9 Changed 3 years ago by pfleck

r11331 Updated links for GoldenFormat based instance providers.

comment:10 Changed 3 years ago by pfleck

  • Owner changed from pfleck to mkommend
  • Status changed from accepted to reviewing

comment:11 Changed 3 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from reviewing to readytorelease

comment:12 Changed 3 years ago by pfleck

  • Resolution set to done
  • Status changed from readytorelease to closed

r11333 Merged r11285, r11286, r11287 and r11331 into stable.

Note: See TracTickets for help on using tickets.