Free cookie consent management tool by TermsFeed Policy Generator

Changes between Initial Version and Version 1 of ReviewHeuristicLab3.3.0CodeOperators


Ignore:
Timestamp:
03/05/10 03:54:11 (13 years ago)
Author:
swagner
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • ReviewHeuristicLab3.3.0CodeOperators

    v1 v1  
     1= [wiki:ReviewHeuristicLab3.3.0Code HeuristicLab 3.3.0 Code Review] - !HeuristicLab.Operators-3.3 =
     2
     3== Reviewer: swinkler ==
     4
     5 * In `Comparator.Apply` the code fragments of the cases `GreaterOrEqual` and `Greater` are swapped.
     6   * swagner: Fixed in r2831.
     7 * General comment: As already discussed in another context, I would suggest storing the names of parameters in static keys.
     8 * In `ValuesCollector` I would suggest to modify the first sentence of the note in lines 63-65 to "The !ItemsReplaced event does not have to be handled here [...]".
     9   * swagner: Changed in r2831.