Free cookie consent management tool by TermsFeed Policy Generator
wiki:ReviewHeuristicLab3.3.0CodeOperators

HeuristicLab 3.3.0 Code Review - HeuristicLab.Operators-3.3

Reviewer: swinkler

  • In Comparator.Apply the code fragments of the cases GreaterOrEqual and Greater are swapped.
    • swagner: Fixed in r2831.
  • General comment: As already discussed in another context, I would suggest storing the names of parameters in static keys.
  • In ValuesCollector I would suggest to modify the first sentence of the note in lines 63-65 to "The ItemsReplaced event does not have to be handled here [...]".
    • swagner: Changed in r2831.
Last modified 13 years ago Last modified on 03/05/10 03:54:11