Free cookie consent management tool by TermsFeed Policy Generator

Opened 15 years ago

Last modified 14 years ago

#863 closed task

HeuristicLab 3.3 Code review — at Version 8

Reported by: gkronber Owned by: swagner
Priority: highest Milestone: HeuristicLab 3.3.0
Component: General Version: 3.3
Keywords: Cc:

Description (last modified by swagner)

This ticket tracks efforts of the code review of all components related to HeuristicLab 3.3:

  • HeuristicLab.PluginInfrastructure
  • HeuristicLab.Persistence-3.3
  • HeuristicLab.Persistence.GUI-3.3
  • HeuristicLab.Persistence.UnitTest
  • HeuristicLab.Common-3.2
  • HeuristicLab.Common.Resources-3.2
  • HeuristicLab.MainForm-3.2
  • HeuristicLab.MainForm.WindowsForms-3.2
  • HeuristicLab.Collections-3.3
  • HeuristicLab.Core-3.3
  • HeuristicLab.Core.Views-3.3
  • HeuristicLab.Data-3.3
  • HeuristicLab.Data.Views-3.3
  • HeuristicLab.Operators-3.3
  • HeuristicLab.Operators.Views-3.3
  • HeuristicLab.Optimizer-3.3
  • HeuristicLab.Parameters-3.3
  • HeuristicLab.Parameters.Views-3.3
  • HeuristicLab.Random-3.3
  • HeuristicLab.SequentialEngine-3.3
  • HeuristicLab.Tracing-3.2

All review comments should be published on the wiki pages of the HeuristicLab 3.3 Release Review?.

Change History (10)

Changed 15 years ago by gkronber

Code review PluginInfrastructure abeham 2010-02-02

comment:1 Changed 15 years ago by gkronber

PluginInfrastructure: PluginBase and ApplicationBase should be renamed to Plugin and Application.

comment:2 Changed 15 years ago by gkronber

Fixed issues in plugin infrastructure as identified by abeham with r2748.

comment:3 Changed 15 years ago by swagner

  • Component changed from ### Undefined ### to General
  • Priority changed from major to blocker
  • Status changed from new to assigned
  • Summary changed from Code review to HeuristicLab 3.3 Code review
  • Version changed from 3.2 to 3.3

comment:4 Changed 15 years ago by swagner

  • Status changed from assigned to new

comment:5 Changed 15 years ago by swagner

  • Description modified (diff)

Changed 15 years ago by abeham

comment:6 follow-up: Changed 15 years ago by abeham

I added my final version including some static code analysis charts generated with SourceMonitor. I also updated the Code Issues section, one remark I had about sanity checks in PluginAttribute proved to be unnecessary when I looked into PluginValidator. A plugin with empty name is discarded there already, the exception in the constructor will not fire. Still for consistency, I think it's okay.

comment:7 in reply to: ↑ 6 Changed 15 years ago by gkronber

Replying to abeham:

I added my final version including some static code analysis charts generated with SourceMonitor. I also updated the Code Issues section, one remark I had about sanity checks in PluginAttribute proved to be unnecessary when I looked into PluginValidator. A plugin with empty name is discarded there already, the exception in the constructor will not fire. Still for consistency, I think it's okay.

Implemented changes as suggested by abeham after code review and simplified method PluginValidator.GetPluginDescription() with r2763.

comment:8 Changed 15 years ago by swagner

  • Description modified (diff)
Note: See TracTickets for help on using tickets.