Selecting many items in a large ItemListView takes a long time

[abeham]

In !ItemListView_T.cs line 124:

removeButton.Enabled = false;
if(itemsListView.SelectedItems.Count > 0) {
  removeButton.Enabled = true;
}

should better be

if (itemsListView.SelectedItems.Count > 0)
  removeButton.Enabled = true;
else
  removeButton.Enabled = false;

My assumption is that switching removeButton from disabled to enabled causes a GUI update every time an item is added to the selection. This can also be seen in the GUI.

I assume removeButton.Enabled = true doesn't fire a GUI update when it was enabled before, otherwise a check if (!removeButton.Enabled) should be added before enabling the removeButton.

[abeham]

prettified description

[abeham]

patch for itemlistview

[abeham]

added a patch, tested it quickly in a workbench where I noticed the bug. Selecting multiple items now is much faster.

Please review

[swagner]

Thanks. Applied the patch to HL 3.2 and HL 3.3 in r2558.

[swagner]

Milestone Iteration 4 deleted

[swagner]

Milestone Current deleted