Free cookie consent management tool by TermsFeed Policy Generator

Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#809 closed enhancement (done)

Selecting many items in a large ItemListView takes a long time

Reported by: abeham Owned by: swagner
Priority: medium Milestone: HeuristicLab 3.3.0
Component: Data Version: 3.2
Keywords: Cc:

Description (last modified by abeham)

In !ItemListView_T.cs line 124:

removeButton.Enabled = false;
if(itemsListView.SelectedItems.Count > 0) {
  removeButton.Enabled = true;
}

should better be

if (itemsListView.SelectedItems.Count > 0)
  removeButton.Enabled = true;
else
  removeButton.Enabled = false;

My assumption is that switching removeButton from disabled to enabled causes a GUI update every time an item is added to the selection. This can also be seen in the GUI.

I assume removeButton.Enabled = true doesn't fire a GUI update when it was enabled before, otherwise a check if (!removeButton.Enabled) should be added before enabling the removeButton.

Attachments (1)

itemlistview patch.patch (694 bytes) - added by abeham 13 years ago.
patch for itemlistview

Download all attachments as: .zip

Change History (6)

comment:1 Changed 13 years ago by abeham

  • Description modified (diff)

prettified description

Changed 13 years ago by abeham

patch for itemlistview

comment:2 Changed 13 years ago by abeham

added a patch, tested it quickly in a workbench where I noticed the bug. Selecting multiple items now is much faster.

Please review

comment:3 Changed 13 years ago by swagner

  • Resolution set to fixed
  • Status changed from new to closed

Thanks. Applied the patch to HL 3.2 and HL 3.3 in r2558.

comment:4 Changed 12 years ago by swagner

  • Milestone changed from Iteration 4 to Current

Milestone Iteration 4 deleted

comment:11 Changed 12 years ago by swagner

  • Milestone changed from Current to HeuristicLab 3.3.0

Milestone Current deleted

Note: See TracTickets for help on using tickets.