Opened 13 years ago

Closed 13 years ago

Last modified 10 years ago

#55 closed defect (done)

The variable "ShakingFactor" is not correctly handled in FullTreeShaker and OnePointShaker

Reported by: gkronber Owned by: gkronber
Priority: medium Milestone: HeuristicLab 3.3.0
Component: StructureIdentification Version: 3.0
Keywords: Cc:

Description (last modified by gkronber)

Shakers enqueue the function specific manipulation operation and do not alias the ShakingFactor variable correctly

Change History (7)

comment:1 Changed 13 years ago by gkronber

  • Description modified (diff)
  • Summary changed from The variable "`ShakingFactor`" is not correctly handled in `FullTreeShaker` and `OnePointShaker` to The variable "ShakingFactor" is not correctly handled in FullTreeShaker and OnePointShaker

comment:2 Changed 13 years ago by gkronber

  • Status changed from new to assigned

comment:3 Changed 13 years ago by gkronber

fixed with r88 by:

  • introducing a new class DelegatingOperator that overwrites Execute() of OperatorBase in exactly the same way as CombinedOperator.
  • extending OnePointShaker and FullTreeShaker from DelegatingOperator

DelegatingOperator should be moved to the Operators plugin and CombinedOperator should also extend DelegatingOperator. To fix the code duplication.

comment:4 Changed 13 years ago by gkronber

  • Resolution set to fixed
  • Status changed from assigned to closed

removed code duplication with r89

comment:5 Changed 12 years ago by swagner

  • Milestone changed from 3.0 to Iteration 0

Milestone 3.0 deleted

comment:6 Changed 10 years ago by swagner

  • Milestone changed from Iteration 0 to Current

Milestone Iteration 0 deleted

comment:11 Changed 10 years ago by swagner

  • Milestone changed from Current to HeuristicLab 3.3.0

Milestone Current deleted

Note: See TracTickets for help on using tickets.