Opened 2 years ago

Closed 2 months ago

#3018 closed defect (done)

Interdependence between mutliple HiveJobManagerViews

Reported by: fholzing Owned by: jkarder
Priority: lowest Milestone: HeuristicLab 3.3.17
Component: Hive.Client Version: trunk
Keywords: Cc:

Description

Closing a HiveJobManagerView while having multiple HiveJobManagerViews instantiated empties the Jobs of all HiveJobManagerViews.

Change History (8)

comment:1 Changed 2 years ago by jkarder

  • Status changed from new to accepted

comment:2 Changed 2 years ago by jkarder

  • Owner changed from jkarder to mkommend
  • Status changed from accepted to reviewing

r17221: changed HiveJobManagerView.OnClosed() to only clear the HiveClient if no other view is displaying it

comment:3 Changed 2 years ago by jkarder

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.17

comment:4 Changed 2 years ago by jkarder

r17222: fixed condition

comment:5 follow-up: Changed 2 years ago by mkommend

  • Owner changed from mkommend to jkarder

r17267: Refactored condition for clean up of hive client.

The usage of singletons for hive client is highly frowned upon! Without the used instance pattern most of the clean up logic and coupling issues would not be present.

comment:6 in reply to: ↑ 5 Changed 2 years ago by jkarder

Replying to mkommend:

r17267: Refactored condition for clean up of hive client.

The usage of singletons for hive client is highly frowned upon! Without the used instance pattern most of the clean up logic and coupling issues would not be present.

Thanks for improving readability. Using singletons vs. using multiple service instances is certainly something we should discuss when a new version of Hive will be implemented.

comment:7 Changed 2 months ago by jkarder

  • Status changed from reviewing to readytorelease

Reviewed r17221, r17222 and r17267.

comment:8 Changed 2 months ago by jkarder

  • Resolution set to done
  • Status changed from readytorelease to closed

r18025: merged r17221, r17222 and r17267 into stable

Note: See TracTickets for help on using tickets.