#2861 closed defect (done)

Ctor of ClassificationProblemData is broken

Reported by: mkommend Owned by: mkommend
Priority: high Milestone: HeuristicLab 3.3.15
Component: Problems.DataAnalysis Version: trunk
Keywords: Cc:

Description

The ctor for ClassificationProblemData(IClassificationProblemData classificationProblemData) throws an exception => symbolic classification solutions cannot be created anymore.

Change History (8)

comment:1 Changed 13 months ago by mkommend

  • Status changed from new to accepted

r15498: Corrected ctor in classification problem data.

comment:2 Changed 13 months ago by mkommend

  • Owner changed from mkommend to gkronber
  • Status changed from accepted to reviewing

comment:3 follow-up: Changed 13 months ago by gkronber

  • Owner changed from gkronber to mkommend
  • Status changed from reviewing to assigned

I reviewed r15498, but I don't understand why moving the statement changes the behaviour. Maybe add a comment.

comment:4 in reply to: ↑ 3 Changed 13 months ago by mkommend

Replying to gkronber:

I reviewed r15498, but I don't understand why moving the statement changes the behaviour. Maybe add a comment.

The positive class value depends on the class names and the matching value is retrieved in line 272. However, if the class names are not updated no matching value is found and an exception is thrown line 273. Therefore, the class names parameter has to be updated before the positive class value can be set.

Remark: This bug results in exception of most classification algorithms (sym classification, lda, gpc, ...).

comment:5 Changed 12 months ago by mkommend

  • Owner changed from mkommend to gkronber
  • Status changed from assigned to reviewing

r15517: Added comment highlighting the importance of the correct assignment order in the classificaiton problem data ctor.

comment:6 Changed 12 months ago by gkronber

  • Owner changed from gkronber to mkommend
  • Status changed from reviewing to readytorelease

comment:7 Changed 12 months ago by mkommend

r15522: Merged r15498,r15517 into stable.

comment:8 Changed 12 months ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed
Note: See TracTickets for help on using tickets.