#2827 closed defect (done)

SingleObjectiveTestFunctionSolutionView throws Exception for ProblemSize == 1

Reported by: bwerth Owned by: bwerth
Priority: medium Milestone: HeuristicLab 3.3.15
Component: Problems.TestFunctions.Views Version: trunk
Keywords: Cc:

Description

The SingleObjectiveTestFunctionSolutionView always generates an image for a 2-d representation even if the actual ProblemSize differs (Image is set as invisible). In high dimensional cases this is wasteful and in the one dimensional case it creates OutOfBoundsExceptions.

Change History (8)

comment:1 Changed 16 months ago by bwerth

  • Status changed from new to accepted

comment:2 Changed 16 months ago by bwerth

r15336 added dimensionality check before image generation

comment:3 Changed 16 months ago by bwerth

  • Owner changed from bwerth to abeham
  • Status changed from accepted to reviewing

comment:4 Changed 15 months ago by abeham

  • Owner changed from abeham to bwerth
  • Status changed from reviewing to assigned

Review comments:

  • Either the null check for Content in line 139 is unnecessary or your changes may lead to a NullReferenceException because you access BestRealVector without null checking first.
  • Either the null check for Content.BestRealVector in line 163 is unnecessary or your changes may lead to a NullReferenceException because you access its Length property without null checking first.

comment:5 Changed 15 months ago by bwerth

r15383 changed dimensionality check to be much more defensive

comment:6 Changed 15 months ago by bwerth

  • Owner changed from bwerth to abeham
  • Status changed from assigned to reviewing

comment:7 Changed 15 months ago by abeham

  • Owner changed from abeham to bwerth
  • Status changed from reviewing to readytorelease
  • Version changed from 3.3.14 to trunk

Reviewed and tested r15383: Ok, thanks!

comment:8 Changed 15 months ago by bwerth

  • Resolution set to done
  • Status changed from readytorelease to closed

r15387 merged r15336, r15383 to stable

Note: See TracTickets for help on using tickets.