Opened 3 months ago

Closed 2 months ago

#2815 closed defect (done)

Implement cloning and serialization of P3 correctly

Reported by: mkommend Owned by: mkommend
Priority: medium Milestone: HeuristicLab 3.3.15
Component: Algorithms.ParameterlessPopulationPyramid Version: 3.3.14
Keywords: Cc:

Description

Currently, the internal state of the P3 algorithm during execution is neither cloned nor serialized that in turn hampers the usability of P3 and is an unusual behavior in HL.

Change History (5)

comment:1 Changed 3 months ago by mkommend

  • Status changed from new to accepted

comment:2 Changed 3 months ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from accepted to reviewing

r15301: Corrected cloning and serializing of P3 and associated classes.

comment:3 Changed 2 months ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from reviewing to readytorelease

Reviewed the changes in r15301. I have one comment (that I don't think is necessary to consider here, but for future): The multi-dimensional jagged array occurrances could be cloned in a single line, similar to how you clone clusters, e.g.

occurances = original.occurances.Select(x => x == null ? null : x.Select(y => y.ToArray()).ToArray()).ToArray();

comment:4 Changed 2 months ago by mkommend

r15324: Merged r15301 into stable.

comment:5 Changed 2 months ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed
Note: See TracTickets for help on using tickets.