ObjectDisposedException might crash HL in ProgressView in combination with importing data from CSV file

[gkronber]

I got an exception in the following code when accessing progressBar since it has been disposed. It seems that a unfortunate order of execution might lead to this situation.

In my case it happened when importing data from a CSV file.

    private void UpdateProgressValue() {
      if (InvokeRequired) Invoke((Action)UpdateProgressValue);
      else {
        if (content != null) {
          double progressValue = content.ProgressValue;
          if (progressValue <= 0.0 || progressValue > 1.0) {
            progressBar.Style = ProgressBarStyle.Marquee;
          } else {
            progressBar.Style = ProgressBarStyle.Blocks;
            progressBar.Value = (int)Math.Round(progressBar.Minimum + progressValue * (progressBar.Maximum - progressBar.Minimum));
          }
        }
      }
    }

[gkronber]

r14287: implemented a workaround. Hard to debug.

[gkronber]

Crash is still possible because of a possible context switch and race condition between the if and throw statements.

if (this.IsHandleCreated) throw;

[gkronber]

r14297: catch all InvalidOperationExceptions (ObjectDisposedExceptions) for the invoke in ProgressView

[jkarder]

Reviewed r14287 and r14297, thanks!

[gkronber]

r14881: merged r14287 and r14297 from trunk to stable