ScopeList clones list items twice

[abeham]

The SubScopes collection of an IScope is of type ScopeList. In the ScopeList there is the following copy constructor:

    private ScopeList(ScopeList original, Cloner cloner)
      : base(original, cloner) {
      list = new List<IScope>(original.Select(x => cloner.Clone(x)));
    }

The copy constructor in the base class (ItemList<IScope>) looks as follows

    protected ItemList(ItemList<T> original, Cloner cloner) {
      cloner.RegisterClonedObject(original, this);
      list = new List<T>(original.Select(x => cloner.Clone(x)));
    }

[abeham]

r13450: fixed duplicate clone of list in ScopeList

Note that the items are not actually cloned twice as they're cached. Still, the list is allocated twice. The whole ScopeList class can probably be removed and replaced with ItemList<IScope>.

[ascheibe]

Reviewed r13450, all good.

[abeham]

r13452: merged to stable