Dataset should implement IStringConvertibleMatrix explicitly

[mkommend]

The reason is that IStringConvertibleMatrix is only implemented for displaying the values and to provide a default view. The method of IStringConvertibleMatrix should never be used for other reasons and an explicit interface implementation is beneficial to hide those methods.

[mkommend]

r13427: Implemented IStringConvertibleMatrix explicitly in Dataset.

The only two properties that are not explicitly implemented are Rows and Columns. IMHO these should be implemented explicitly as well and standard properties providing only a getter added. Furthermore, I don't think that counting the rows manually in an integer field gives an benefit compared to

  variableValues.First().Count;

[gkronber]

Reviewed r13427 (changes are ok).

Do you plan to make the changes proposed in comment 2?

[mkommend]

r13539: Implemented rows and columns explicitly in the Dataset.

[mkommend]

Replying to gkronber:

Reviewed r13427 (changes are ok).

Do you plan to make the changes proposed in comment 2?

r13539 implemented the first change proposed in comment 2. I still have to review the implications of changing the rows property.

[mkommend]

I decided to not change the implementation of the row property and leave it as it is => implementation of this ticket is finished.

[gkronber]

Replying to mkommend:

I decided to not change the implementation of the row property and leave it as it is => implementation of this ticket is finished.

Fine by me. Reviewed r13539, please merge to stable.

[mkommend]

r13881: Merged r13427 and r13539 into stable.