CSharp formatter for symbolic data analysis expressions does not produce correct expressions in all cases

[gkronber]

The HL interpreter also allows Boolean operators with real-valued arguments. This is not yet handled correctly by the formatter.

There also seems to be a problem when using only arithmetic operators: Ich vermute, dass der TreeInterpreter ein anderes Ergebnis produziert als der Code den der C# Formatter ausgibt. Ich habe bei mir in einem Testscript einmal die Policy Function als C# Code eingebettet und einmal unter Verwendung des TreeInterpreter. Als C# Code kommt Qualität 0 heraus mit dem TreeInterpreter Qualtät 10. Als Grammatik habe ich nur die ArithmeticExpressionGrammar verwendet.

[gkronber]

See attached script to reproduce the problem

[mkommend]

r13116: Corrected C# formatter for SymbolicExpressionTrees to handle subtractions correctly.

[mkommend]

r13116 should fix the issue that could be reproduced with the attached script. The error was related to the handling of unary subtractions (rare corner case). However, bool operations are still not supported.

Maybe a unit test would be useful to guarantee that the interpreter returns the same results as a function compiled from the tree formatter.

[gkronber]

Reviewed r13116 thanks for the fix.

[gkronber]

Boolean expressions are still not handled correctly by the C# formatter and also by the Mathematica formatter. A new ticket has been created to track that bug (#2514).

[gkronber]

r13240: merged r13116 from trunk to stable