KeyNotFoundException in PushForwardInsertionCreator

[ascheibe]

Run the enclosed HL file for reproducing the error. It seems that GetNearestDepot(..) may return -1 which is stored as a value in the depotAssignment and is not checked later on which leads to this problem.

[pfleck]

The PushForwardInsertionCreator has problems when two or more customers have the same coordinates (the distance between them would be zero).

With a zero-length distance, no costs can be calculated for the tour and no nearest depot can be found, which lead to the exception.

We could check if the distance is zero and calculate the costs differently, but I think a scenario with two customers/depots on the same coordinates is rather unusual.

[pfleck]

r10858

• Implemented a more stable version for calculating the polar angle between two coordinates that allows calculating the angle between two locations with the same coordinates.
• Fixed a radiant/grad bug.

[abeham]

It is to note that the change affects the reproducibility of experiments. Nevertheless, I vote against upgrading the plugin version to 3.5. After all it's a bug fix and the change should not be that grave.

[abeham]

r10928: merged r10858 to stable