Opened 4 years ago

Closed 3 years ago

#2127 closed defect (done)

Visualization in Job Shop Scheduling Problem View doesn't get refreshed when changing problem instances

Reported by: ascheibe Owned by: ascheibe
Priority: medium Milestone: HeuristicLab 3.3.10
Component: Problems.Scheduling.Views Version: 3.3.9
Keywords: Cc:

Description


Change History (12)

comment:1 Changed 4 years ago by ascheibe

  • Status changed from new to accepted

comment:2 Changed 4 years ago by ascheibe

r10213 fixed refreshing of visualization in job shop scheduling problem view

comment:3 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to abeham
  • Status changed from accepted to reviewing

comment:4 Changed 4 years ago by abeham

  • Owner changed from abeham to ascheibe

This still does not work. I can add new jobs to the list which are not reflected in the view, I can change parameters of the jobs and the tasks and they are unrefleted. Job and Task both do not seem to throw ToStringChanged events.

Also I noticed the tab order is wrong in those views.

r10433:

  • Fixed tab order in JobView and TaskView
  • Added additional events and registriations to account for changes to the jobs and tasks

I noticed that we have some overrides of Equals and GetHashCode in Task and Resource. Especially the override in Task creates problems because it uses mutable properties to calculate the hash code. The ItemListView<Task> doesn't update when the task's ToString changes, because then also the hash code changes and it can't find the associated ListViewItem. I didn't address these problems yet. These problems were solved by removing the overrides in Task.

Last edited 4 years ago by abeham (previous) (diff)

comment:5 Changed 4 years ago by gkronber

  • Owner changed from ascheibe to gkronber
  • Status changed from reviewing to assigned

comment:6 Changed 4 years ago by gkronber

  • Status changed from assigned to accepted

comment:7 Changed 4 years ago by gkronber

  • Owner changed from gkronber to abeham
  • Status changed from accepted to reviewing

r10476:

  • removed Equals() and GetHashCode() overrides as well as related static methods.
  • changed ctors of Task and Job to prevent calling virtual members.

comment:8 Changed 4 years ago by gkronber

r10494: fixed failed unit tests after removal of equals / gethashcode methods in schedule encoding.

comment:9 Changed 4 years ago by gkronber

  • Owner changed from abeham to ascheibe
  • Status changed from reviewing to assigned

comment:10 Changed 4 years ago by gkronber

  • Status changed from assigned to reviewing

comment:11 Changed 3 years ago by ascheibe

  • Status changed from reviewing to readytorelease

Reviewed and tested r10433, r10476, r10494. Seems alright. I will merge it into stable.

comment:12 Changed 3 years ago by ascheibe

  • Resolution set to done
  • Status changed from readytorelease to closed

r11073 merged r10213, r10433, r10476, r10494 into stable

Note: See TracTickets for help on using tickets.