Opened 5 years ago

Closed 4 years ago

#2016 closed enhancement (done)

RunCollectionBubbleChart improvements

Reported by: mkommend Owned by: abeham
Priority: medium Milestone: HeuristicLab 3.3.8
Component: Optimization.Views Version: 3.3.8
Keywords: Cc:

Description (last modified by mkommend)

  • Categorical values (e.g., algorithm name) shall be sorted alphabetically (also applies for the BoxPlots)
  • Automatic coloring for large run collections must be faster
  • Selection of runs to apply specific actions

Change History (25)

comment:1 Changed 5 years ago by mkommend

  • Owner changed from swagner to sforsten
  • Status changed from new to assigned

comment:2 Changed 5 years ago by mkommend

r9235: Implemented changes in BubbleChart and BoxPlots to improve the coloring and the display of categorical values.

comment:3 Changed 5 years ago by sforsten

  • Status changed from assigned to accepted

r9236:

  • Content.UpdateOfRunsInProgress is set to true while updating the colors of the data points in RunCollectionBubbleChartView
  • removed a useless line in RunCollectionBoxPlotView

comment:4 Changed 5 years ago by sforsten

  • Owner changed from sforsten to mkommend
  • Status changed from accepted to reviewing

comment:5 Changed 5 years ago by mkommend

  • Owner changed from mkommend to ascheibe

comment:6 Changed 5 years ago by mkommend

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.8

comment:7 Changed 4 years ago by ascheibe

  • Owner changed from ascheibe to mkommend
  • Status changed from reviewing to readytorelease

Thanks, looks good!

comment:8 Changed 4 years ago by mkommend

  • Status changed from readytorelease to assigned

comment:9 Changed 4 years ago by mkommend

  • Status changed from assigned to accepted

comment:10 Changed 4 years ago by mkommend

  • Description modified (diff)
  • Owner changed from mkommend to abeham
  • Status changed from accepted to reviewing

r9312: Changes in the bubblechart:

  • Added possibility to select runs.
  • Added option to hide all selected runs.
  • Performance improvements regarding coloring, filtering and selection.
  • Corrected minor bug regarding categorical values in the bubblechart and boxplot view.

Remark: All changesets except r9312 have been already been reviewed.

comment:11 Changed 4 years ago by mkommend

r9313: Corrected text alignment of the newly introduced buttons in the bubblechart.

comment:12 Changed 4 years ago by mkommend

  • Owner changed from abeham to mkommend
  • Status changed from reviewing to assigned

comment:13 Changed 4 years ago by sforsten

  • Owner changed from mkommend to sforsten
  • Status changed from assigned to accepted

r9340: fixed bug: an exception was thrown, when a bubblechart was open and the runs have been cleared, because UpdateMarkerSizes was called. A check was added if points are available in the diagram.

comment:14 Changed 4 years ago by sforsten

  • Owner changed from sforsten to mkommend
  • Status changed from accepted to reviewing

comment:15 Changed 4 years ago by sforsten

  • Owner changed from mkommend to sforsten
  • Status changed from reviewing to assigned

ToDo:

  • Selection of mutliple runs when holding "Ctrl"
  • improve color selection
  • add "Unhide all" and "Color reset" option in context menu
  • increase default bubble size
  • restructure context menu
  • fix bugs in BoxPlot: if runs in BubbleChart are hidden, the labels in BoxPlot are incorrect.

Maybe selection should be persisted or a property selection should be added to runs

comment:16 Changed 4 years ago by mkommend

  • Owner changed from sforsten to mkommend
  • Status changed from assigned to accepted

r9435: Added patch from sforsten, that improves the BubbleChart- and BoxPlotView, that implements all previously mentioned comments.

comment:17 Changed 4 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from accepted to reviewing

comment:18 follow-up: Changed 4 years ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from reviewing to assigned

r9441: Changed the LogTransform for transparency to a steeper curve. ln(x+1)/ln(2.0) is still almost linear for x in [0;1]. I changed this to (1-0.05x)/0.95.

Remaining points:

  • The private variable transperencyExponent is not used anywhere (and spelled wrong)
  • The private variable runToHide is also not used anywhere
  • The method HideRuns takes an IEnumerable<IRun> that is not used, it iterates over selectedRuns instead
  • run.Color = Color.Black; in line 830: Color.Black should be a constant or static readonly field
  • point.Color = Color.Red; in line 173: Color.Red should be a constant or static readonly field
  • In method GetValue(IRun, SizeDimension) the first parameter is not used.

comment:19 Changed 4 years ago by mkommend

  • Status changed from assigned to accepted

comment:20 Changed 4 years ago by sforsten

r9447: added toggle of selection for single data points

comment:21 Changed 4 years ago by mkommend

r9448: Removed unused code in the BubbleChartView.

comment:22 in reply to: ↑ 18 Changed 4 years ago by mkommend

Review comments:

  • The private variable transperencyExponent is not used anywhere (and spelled wrong)
  • The private variable runToHide is also not used anywhere
  • The method HideRuns takes an IEnumerable<IRun> that is not used, it iterates over selectedRuns instead

The three review comments above were addressed in r9448.

  • run.Color = Color.Black; in line 830: Color.Black should be a constant or static readonly field
  • point.Color = Color.Red; in line 173: Color.Red should be a constant or static readonly field

I decided against static fields regarding the default values for the run color, because this should be a property of the Run itself and furthermore there should be more general visual styles implemented. This will be addressed in another ticket / release.

  • In method GetValue(IRun, SizeDimension) the first parameter is not used.

This is due to consistency reasons with the other GetValue methods.

comment:23 Changed 4 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from accepted to reviewing

comment:24 Changed 4 years ago by abeham

  • Status changed from reviewing to readytorelease

ok

comment:25 Changed 4 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.7 to 3.3.8
Note: See TracTickets for help on using tickets.