The Hive JobManager should show the jobs per user sorted by date

[mkommend]

The JobManager currently shows the job sorted alphabetically, which makes it hard to find the latest ones.

[ascheibe]

r8702 added a comparer for sorting the jobs in the Hive Job Manager by date

[mkommend]

Reviewing Comments

• Use as cast and a null check instead of is condition
• Use DateTime.TryParse instead of catching an exception
• Rename ListViewDataComparer to ListViewItemComparer, because it handles ListViewItems instead of ListViews and can also compares strings.
• Why can strings and DateTimes handled correctly, but numerical values ignored? Is there a specific reason for this?
• Is an InvalidArgumentException more appropriate than an InvalidCastException?

The functionality works perfectly, so the reviewing comments are more or less hints to further improve the code quality.

[ascheibe]

r8708 implemented reviewing comments

[ascheibe]

Concerning your fourth comment: Handling of strings is a fallback if date conversion fails. I don't think we should also check for numerical values if date conversion fails, it would be probably better to throw an exception and remove sorting using strings?

[ascheibe]

r8718 removed string comparison

[ascheibe]

r8850 fixed a bug which occurs on systems that don't use german time format

[ascheibe]

@Bogdan: Could you please check if it works now for you?

[bburlacu]

Hive - sorted jobs view

[bburlacu]

It works, yes.

Screenshot:

[ascheibe]

Thanks, I'm setting this ticket therefore readytorelease.