Opened 12 years ago
Closed 11 years ago
#1953 closed enhancement (done)
Improve the Vehicle Routing implementation
Reported by: | svonolfe | Owned by: | svonolfe |
---|---|---|---|
Priority: | medium | Milestone: | HeuristicLab 3.3.8 |
Component: | Problems.VehicleRouting | Version: | 3.3.8 |
Keywords: | Cc: |
Description (last modified by svonolfe)
Some issues and feature requests have been discovered in the VRP 3.4 implementation.
svonolfe:
the distance matrix is reset when starting an algorithmsome instances of the LiLim benchmark instances are not named correctlyvehicles are not assigned correctly when a solution includes empty trips
mkommend:
the view should be improved to show the parameters of the problemthe design of the instance interpreters could be improved to avoid code duplication
Change History (15)
comment:1 Changed 12 years ago by svonolfe
- Status changed from new to accepted
comment:2 Changed 12 years ago by svonolfe
comment:3 Changed 12 years ago by svonolfe
Fixed naming of the LiLim instances in r8650
comment:4 Changed 12 years ago by svonolfe
Imrpoved VRP problem instance view in r8651
comment:5 Changed 12 years ago by svonolfe
The distance matrix was reset when starting an algorithm the first time (r8652)
comment:6 Changed 12 years ago by svonolfe
- Description modified (diff)
comment:7 Changed 12 years ago by svonolfe
vehicles were not assigned correctly when a solution includes empty trips (r8653)
comment:8 Changed 12 years ago by svonolfe
- Description modified (diff)
comment:9 Changed 11 years ago by svonolfe
- Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.8
- Owner changed from svonolfe to mkommend
- Status changed from accepted to reviewing
comment:10 Changed 11 years ago by mkommend
- Owner changed from mkommend to svonolfe
- Status changed from reviewing to assigned
Reviewing comments:
- Use explicit conversions (casts) in Interpreters instead of the as operator.
- IVRPDataInterpreter.GetDataType is not used anywhere.
- Remove the local field distanceMatrix from the VRPProblemInstance and refactor the GetDistance method.
I would suggest that you fix parameters which are determined by the loaded problem instance, e.g. vehicles, depots.
comment:11 Changed 11 years ago by mkommend
r8922: Refactored GetDistance method in VRPProblemInstace.
comment:12 Changed 11 years ago by svonolfe
r9010: used explicit conversions in Interpreters and removed the unused method IVRPDataInterpreter.GetDataType
comment:13 Changed 11 years ago by svonolfe
- Owner changed from svonolfe to mkommend
- Status changed from assigned to reviewing
comment:14 Changed 11 years ago by mkommend
- Owner changed from mkommend to svonolfe
- Status changed from reviewing to readytorelease
comment:15 Changed 11 years ago by swagner
- Resolution set to done
- Status changed from readytorelease to closed
- Version changed from 3.3.7 to 3.3.8
Improved the design of the interpreters so code duplication is avoided in r8649