CheckTypeCompatibility does not check constraints on generic type parameters

[mkommend]

The CheckTypeCompatibility in all ApplicationManagers could be further optimized by checking the constraints of generic type parameters in addition to the creation of concrete types and assigning the generic types.

[mkommend]

Accidentally commited changes in LightweightApplicationManager and SandboxApplicationManager with r8531, which adds a check for the new and class constraint on generic types.

[mkommend]

The change in r8531 is only a minor change in the PluginInfrastructure as no new method got added or method signature changed. Only the behavior of the CheckTypeCompatibility was enhanced by additional constraint checks. Furthermore, I have tested the changeset thoroughly, as I worked locally with this modified version for over two weeks.

[mkommend]

In r8531 an error was introduced regarding the discovery of generic types and some unit tests failed during the build.

[mkommend]

r8536: Reverse merged r8531 (changes in application managers) as this introduced errors in the type discovery.

[mkommend]

The unit test should pass now, since the changes got reverted. However, I am not completely sure if the TypeCompatibilityCheck works correctly for generic types. We should discuss this issue and that's why I leave this ticket open.

[mkommend]

It was decided to specify the behavior of the type discovery by unit tests and to reimplement the type compatibility check.

[mkommend]

r8571:

• Rewrote type checks for type discovery of plugin infrastructure
• Extracted common functionality of ApplicationManagers in another class.
• Added unit tests for the newly implemented methods*
• Updated test lists to include the new unit tests

[mkommend]

It was decided that generic types should only be returned if the generic type parameter is exactly the same.

[mkommend]

r8577: Changed type discovery to return only generic types with exactly the same type parameter and adapted the unit test accordingly.

[mkommend]

Please feel free to extend the test coverage by adding more test cases during the review.

[gkronber]

Reviewed r8571 and r8577. The implementation is very clear and readable and tested trough unit tests. I'm happy with the change even though type discovery is still very slow (see #1972)