Opened 12 years ago
Closed 12 years ago
#1899 closed enhancement (done)
Diversity Analyzers should use the new Diversity Calculators from Scatter Search
Reported by: | ascheibe | Owned by: | jkarder |
---|---|---|---|
Priority: | medium | Milestone: | HeuristicLab 3.3.8 |
Component: | Analysis | Version: | 3.3.8 |
Keywords: | Cc: |
Description
With Scatter Search also new Similarity Calculators will be merged to trunk. These calculators should also be used for calculating the population diversity in the PopulationDiversityAnalyzer. Implement therefore a PopulationDiversityAnalyzer without the <T> parameter which uses the problem-specific similarity calculators. The old one should be left in trunk but marked deprecated and for removal with HL 3.4. Also hide the old analyzer in the GUI.
Change History (17)
comment:1 Changed 12 years ago by ascheibe
- Owner changed from ascheibe to jkarder
- Status changed from new to assigned
comment:2 Changed 12 years ago by jkarder
- Status changed from assigned to accepted
comment:3 Changed 12 years ago by jkarder
comment:4 Changed 12 years ago by jkarder
- Owner changed from jkarder to ascheibe
- Status changed from accepted to reviewing
comment:5 Changed 12 years ago by ascheibe
r8482 removed setting the checked state of certain analyzers in the samples unit test as this is already done correctly with the EnabledByDefault property of the analyzers
comment:6 Changed 12 years ago by ascheibe
- Owner changed from ascheibe to jkarder
- Status changed from reviewing to assigned
Thanks for implementing this. The new analyzer looks good. We should not only add it to the TSP but to all problems where we already have similarity calculators. Additionally the old similarity analyzers as well as the PopulationDiversityAnalyzer class should be marked as deprecated (please mark them with the "Backwards compatible code, remove with 3.4" region).
comment:7 Changed 12 years ago by jkarder
r8720: applied the changes suggested by ascheibe in comment:6:ticket:1899
comment:8 Changed 12 years ago by jkarder
- Owner changed from jkarder to ascheibe
- Status changed from assigned to reviewing
comment:9 Changed 12 years ago by jkarder
Thanks for the review.
comment:10 Changed 12 years ago by ascheibe
- Owner changed from ascheibe to jkarder
- Status changed from reviewing to readytorelease
Thanks a lot, looks good!
comment:11 Changed 12 years ago by jkarder
Thanks!
comment:12 Changed 12 years ago by ascheibe
- Status changed from readytorelease to assigned
I just found a bug in the analyzer. The storable property of the SimilarityCalculator in SingleObjectivePopulationDiversityAnalyzer is missing as well as cloning of the SimilarityCalculator.
comment:13 Changed 12 years ago by jkarder
- Status changed from assigned to accepted
comment:14 Changed 12 years ago by jkarder
- added the Storable attribute to the similarity calculator
- fixed cloning ctor
comment:15 Changed 12 years ago by jkarder
- Owner changed from jkarder to ascheibe
- Status changed from accepted to reviewing
Thanks for the bug report!
comment:16 Changed 12 years ago by ascheibe
- Owner changed from ascheibe to jkarder
- Status changed from reviewing to readytorelease
Thanks a lot!
comment:17 Changed 12 years ago by swagner
- Resolution set to done
- Status changed from readytorelease to closed
- Version changed from 3.3.7 to 3.3.8
r8478: added population diversity analyzer which uses problem specific similarity calculators