Opened 12 years ago
Closed 12 years ago
#1897 closed task (done)
Upgrade protocol buffer version
Reported by: | abeham | Owned by: | abeham |
---|---|---|---|
Priority: | medium | Milestone: | HeuristicLab 3.3.8 |
Component: | ExtLibs | Version: | 3.3.8 |
Keywords: | Cc: |
Description
Upgrade the plugin from 0.9.1 (May 2010) to 2.4.1 (October 2011).
Change History (8)
comment:1 Changed 12 years ago by abeham
- Owner changed from mkommend to abeham
- Status changed from new to accepted
comment:2 Changed 12 years ago by abeham
comment:3 Changed 12 years ago by abeham
r8296: added quotes in case path contains spaces
comment:4 Changed 12 years ago by abeham
- Owner changed from abeham to mkommend
- Status changed from accepted to reviewing
comment:5 follow-up: ↓ 6 Changed 12 years ago by mkommend
comment:6 in reply to: ↑ 5 ; follow-up: ↓ 7 Changed 12 years ago by mkommend
- Owner changed from mkommend to abeham
- Status changed from reviewing to readytorelease
Replying to mkommend:
Reviewed change sets r8295 and r8296. One thing I noticed is that the generated assembly ProtoGen is not included by the HL plugin and I am not sure if this should be the case as it is used by the ExternalEvaluation plugin.
In a discussion with abeham it turns out that this behavior is intended.
comment:7 in reply to: ↑ 6 Changed 12 years ago by abeham
Replying to mkommend:
Replying to mkommend:
Reviewed change sets r8295 and r8296. One thing I noticed is that the generated assembly ProtoGen is not included by the HL plugin and I am not sure if this should be the case as it is used by the ExternalEvaluation plugin.
In a discussion with abeham it turns out that this behavior is intended.
To state my argument in this ticket: First, ProtoGen doesn't work as a standalone, but also needs Google's protoc compiler. So that's two more executables in our bin directory. I think legally we could ship both of them, but the question is: Does it make sense? ProtoGen is used to produce C# code out of .proto files. I guess anybody that wants to use this for external evaluation does so, because his or her external application is written in a different language than C#. Since everything you need to make proto-based applications is available on the web (code.google.com) and pretty easy to find I decided against including it.
comment:8 Changed 12 years ago by swagner
- Resolution set to done
- Status changed from readytorelease to closed
- Version changed from 3.3.7 to 3.3.8
r8295: