Type names of operators are not shown in the OperatorGraphView

[swagner]

The type names of operators are not shown in the OperatorGraphView. Therefore it is hard to identify an operator, if the operator name has been changed.

[mkommend]

r7199: Added type name to operator shapes.

[swagner]

Thanks for implementing this feature. I reviewed the changes and have the following comments:

• Are the setters of OperatorShape.TypeName and OperatorShapeInfo.TypeName really necessary? In my opinion the type name should not change.
• Initializing typeName with title in OperatorShapeInfo.AfterDeserialization is critical when loading old algorithms. If the algorithm contains operators with changed names, the title of these operators is not the type name anymore. In this case OperatorShapeInfo.TypeName is set to a wrong value.
• When setting an operator name back to the original type name, the type name string in the shape disappears as desired, but the size of the shape is not changed.
• When changing an operator name from the original type name to something else in an expanded shape, the type name string overlaps with the string of the first parameter.

[mkommend]

r7226: Corrected display of type names in OperatorShapes.

[mkommend]

Replying to swagner: Changes made in r7226

• Are the setters of OperatorShape.TypeName and OperatorShapeInfo.TypeName really necessary? In my opinion the type name should not change.

Changed the property name to subtitle, because this property can be used for other information as well. This was also the intention of the setter.

• Initializing typeName with title in OperatorShapeInfo.AfterDeserialization is critical when loading old algorithms. If the algorithm contains operators with changed names, the title of these operators is not the type name anymore. In this case OperatorShapeInfo.TypeName is set to a wrong value.

Corrected.

• When setting an operator name back to the original type name, the type name string in the shape disappears as desired, but the size of the shape is not changed.

Corrected.

• When changing an operator name from the original type name to something else in an expanded shape, the type name string overlaps with the string of the first parameter.

Corrected.

[swagner]

Great. Thanks.