Opened 10 years ago

Closed 10 years ago

#1470 closed defect (done)

AlleleFrequencyCollectionView should show alleles in lexicographic order

Reported by: abeham Owned by: abeham
Priority: high Milestone: HeuristicLab 3.3.5
Component: Analysis.Views Version: 3.3.5
Keywords: Cc:

Description (last modified by abeham)

Currently the allele frequncy columns in the chart are ordered by AverageImpact in line 115 and line 123 of AlleleFrequencyCollectionView.cs. Which means that the place on the x-axis is not fixed for a specific allele in all cases. For the TSP it is fixed as the impact of the allele denotes the length of the edge and is thus independent of the presence of other alleles. But in case of the QAP an allele is the assignment of a certain facility to a certain location. Unless I'm not mistaken on the meaning of an allele's impact, for the QAP it is the sum of the weighted distances to all other assigned facilities. This of course highly depends on which other alleles are present. It could thus be that one allele can have at one time a higher and at another time a lower impact than in the best known solution. This would change the order of the optimal alleles and the columns would appear to be "jumping around" on the x-axis. Sorting the alleles in a lexicographic fashion, such as by allele id would always display the alleles on the same x-position (at least those that appear in the BestKnownSolution).

In changing this, I think the average impact series should by be enabled again by default.

Change History (8)

comment:1 Changed 10 years ago by abeham

  • Description modified (diff)

comment:2 Changed 10 years ago by swagner

Sorting the alleles lexicographically by their id and enabling the impact series is absolutely fine for me. Please feel free to change this.

comment:3 Changed 10 years ago by abeham

  • Owner changed from swagner to abeham
  • Status changed from new to accepted
  • Version changed from 3.3.3 to branch

r5999

  • Changed sorting of alleles in AlleleFrequencyCollectionView

comment:4 Changed 10 years ago by abeham

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.4

comment:5 Changed 10 years ago by abeham

  • Milestone changed from HeuristicLab 3.3.4 to HeuristicLab 3.3.5

comment:6 Changed 10 years ago by abeham

  • Owner changed from abeham to swagner
  • Status changed from accepted to reviewing
  • Version changed from branch to 3.3.4

r6342

  • merged to trunk

comment:7 Changed 10 years ago by swagner

  • Owner changed from swagner to abeham
  • Status changed from reviewing to readytorelease

Great. Thanks.

comment:8 Changed 10 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.4 to 3.3.5
Note: See TracTickets for help on using tickets.