Opened 8 years ago

Closed 8 years ago

#1453 closed enhancement (done)

OnlineEvaluators must not throw exceptions due to performance reasons

Reported by: mkommend Owned by: gkronber
Priority: medium Milestone: HeuristicLab 3.3.4
Component: Problems.DataAnalysis Version: 3.3.4
Keywords: Cc:

Description


Change History (20)

comment:1 Changed 8 years ago by mkommend

  • Status changed from new to accepted

comment:2 Changed 8 years ago by gkronber

  • Owner changed from mkommend to gkronber
  • Status changed from accepted to assigned

comment:3 Changed 8 years ago by gkronber

  • Status changed from assigned to accepted

comment:4 Changed 8 years ago by gkronber

r5845: changed OnlineEvaluators so that they do not throw an ArgumentException on receiving infinity of NaN values but instead return double.NaN as result.

comment:5 Changed 8 years ago by gkronber

r5846: changed *RSquaredEvaluators to return 0.0 (worst possible value) if the result returned by the OnlinePearsonsRSquaredEvaluator is double.NaN

comment:6 Changed 8 years ago by gkronber

  • Owner changed from gkronber to mkommend
  • Status changed from accepted to reviewing

comment:7 Changed 8 years ago by mkommend

  • Owner changed from mkommend to gkronber
  • Status changed from reviewing to assigned

Please also adapt the OnlineAccuracyEvaluator.

comment:8 Changed 8 years ago by gkronber

As discussed with mkommend OnlineAccuracyEvaluator should not be adapted.

Instead an additional property (with a flag enum value) should be added that indicates error conditions.

Last edited 8 years ago by gkronber (previous) (diff)

comment:9 Changed 8 years ago by gkronber

r5894: Added an ErrorState property to online evaluators to indicate if the result value is valid or if there has been an error in the calculation. Adapted all classes that use one of the online evaluators to check this property.

comment:10 Changed 8 years ago by gkronber

r5897: fixed build fail by reverting unintentionally committed changes

comment:11 Changed 8 years ago by gkronber

r5904: improved performance of online evaluators.

comment:12 Changed 8 years ago by mkommend

  • Owner changed from gkronber to mkommend
  • Status changed from assigned to accepted

comment:13 Changed 8 years ago by mkommend

r5942: Renamed IOnlineEvaluator to IOnlineCalculator.

comment:14 Changed 8 years ago by mkommend

r5943: Updated directory name of OnlineCalculators.

comment:15 Changed 8 years ago by mkommend

r5945: Stopped iterating over the enumerables in the static calculate method in OnlineCalculators.

comment:16 Changed 8 years ago by mkommend

r5952: Added UnitTest for OnlineCalculators to enable performance monitoring.

comment:17 Changed 8 years ago by mkommend

  • Owner changed from mkommend to gkronber
  • Status changed from accepted to reviewing

comment:18 Changed 8 years ago by mkommend

r5963: Added error state assert in OnlineCalculatorPerformanceTest.

comment:19 Changed 8 years ago by gkronber

  • Status changed from reviewing to readytorelease

Reviewed r5942, r5943, r5945, r5952 and r5963.

comment:20 Changed 8 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.3 to 3.3.4
Note: See TracTickets for help on using tickets.