Opened 9 years ago

Closed 9 years ago

#1451 closed enhancement (done)

ResultCollections should only show the value of the selected result in the details viewhost

Reported by: mkommend Owned by: mkommend
Priority: medium Milestone: HeuristicLab 3.3.4
Component: Optimization.Views Version: 3.3.4
Keywords: Cc:

Description


Change History (17)

comment:1 Changed 9 years ago by mkommend

  • Status changed from new to accepted

comment:2 Changed 9 years ago by mkommend

  • Owner changed from mkommend to swagner
  • Status changed from accepted to reviewing

r5819: Displayed result value in details group box of ResultCollectionView.

comment:3 Changed 9 years ago by mkommend

  • Component changed from Operators.Views to Optimization.Views

comment:4 Changed 9 years ago by mkommend

  • Owner changed from swagner to mkommend
  • Status changed from reviewing to assigned

comment:5 Changed 9 years ago by mkommend

r5831: Fixed updating of result views in ResultCollectionView.

comment:6 Changed 9 years ago by mkommend

  • Owner changed from mkommend to swagner
  • Status changed from assigned to reviewing

comment:7 Changed 9 years ago by gkronber

r5842: added missing check for InvokeRequired in ResultsCollectionView

comment:8 Changed 9 years ago by swagner

Thanks for implementing this nice and very reasonable enhancement.

Review comments:

  • Reusing the method itemsListView_SelectedIndexChanged as a handler for the ValueChanged event of a result might be a bit misleading. I recommend to implement a specific event handler for ValueChanged and to put the code for updating the details view into a separate method.
  • For unification reasons I think we should consider to follow the same approach as it was implemented for variables (cf. VariableView and VariableValueView).

comment:9 Changed 9 years ago by swagner

  • Status changed from reviewing to assigned

comment:10 Changed 9 years ago by swagner

  • Status changed from assigned to accepted

comment:11 Changed 9 years ago by swagner

Implemented review comments in r5875.

comment:12 Changed 9 years ago by swagner

  • Owner changed from swagner to mkommend
  • Status changed from accepted to reviewing

comment:13 Changed 9 years ago by mkommend

  • Status changed from reviewing to assigned

comment:14 Changed 9 years ago by mkommend

  • Status changed from assigned to accepted

comment:15 Changed 9 years ago by mkommend

  • Owner changed from mkommend to swagner
  • Status changed from accepted to reviewing

r5896: Corrected implementation of ResultCollectionView and changed default views for Results.

comment:16 Changed 9 years ago by swagner

  • Owner changed from swagner to mkommend
  • Status changed from reviewing to readytorelease

Thanks. I think this is a very nice solution now.

comment:17 Changed 9 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.3 to 3.3.4
Note: See TracTickets for help on using tickets.