Opened 11 years ago

Closed 11 years ago

#1445 closed defect (done)

Runs disappear in moved Optimizer in an Experiment

Reported by: cfischer Owned by: swagner
Priority: high Milestone: HeuristicLab 3.3.4
Component: Core.Views Version: 3.3.4
Keywords: Cc:

Description (last modified by cfischer)

Steps to reproduce:

  • Experiment with two Optimizers (e.g. GA, BatchRun, ...) where each Optimizer contains Runs
  • Select one Optimizer and click the Move Up or Move Down button
  • The Runs from the moved Optimizer disappear

Reason:

Due to the implementation of the Move Up/Down methods (swap) the ItemListView contains the same object twice during the swap (the Optimizer that is moving). The event handler optimizer_Runs_ItemsRemoved is subscribed twice in the Experiment. This leads to the disappearing Runs in the Optimizer. (compare also the attached stacktraces where Experiment.Runs_ItemsRemoved is called twice)

Possible Solutions:

  1. Different Implementation of Move Up/Down methods in ItemListView (possible side effects from other uses of ItemListView?)
  2. Ensure that the event handler is only subscribed once in the Experiment (e.g. unsubscribe before subscription or something like (1)).

(1) http://stackoverflow.com/questions/136975/has-an-event-handler-already-been-added

Attachments (2)

stacktrace1.txt (2.7 KB) - added by cfischer 11 years ago.
stacktrace2.txt (4.3 KB) - added by cfischer 11 years ago.

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by cfischer

Changed 11 years ago by cfischer

comment:1 Changed 11 years ago by cfischer

  • Description modified (diff)

comment:2 Changed 11 years ago by mkommend

  • Cc cfischer removed
  • Milestone changed from HeuristicLab Backlog to HeuristicLab 3.3.4
  • Owner changed from mkommend to swagner
  • Priority changed from medium to high
  • Status changed from new to assigned

comment:3 Changed 11 years ago by swagner

  • Status changed from assigned to accepted

comment:4 Changed 11 years ago by swagner

Fixed in r5928.

comment:5 Changed 11 years ago by swagner

  • Component changed from Optimization to Core.Views
  • Keywords experiment runs removed
  • Owner changed from swagner to mkommend
  • Status changed from accepted to reviewing

comment:6 Changed 11 years ago by mkommend

  • Owner changed from mkommend to swagner
  • Status changed from reviewing to readytorelease

Reviewed changeset r5928.

comment:7 Changed 11 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.3 to 3.3.4
Note: See TracTickets for help on using tickets.