Runs disappear in moved Optimizer in an Experiment

[cfischer]

Steps to reproduce:

• Experiment with two Optimizers (e.g. GA, BatchRun, ...) where each Optimizer contains Runs
• Select one Optimizer and click the Move Up or Move Down button
• The Runs from the moved Optimizer disappear

Reason:

Due to the implementation of the Move Up/Down methods (swap) the ItemListView contains the same object twice during the swap (the Optimizer that is moving). The event handler optimizer_Runs_ItemsRemoved is subscribed twice in the Experiment. This leads to the disappearing Runs in the Optimizer. (compare also the attached stacktraces where Experiment.Runs_ItemsRemoved is called twice)

Possible Solutions:

1. Different Implementation of Move Up/Down methods in ItemListView (possible side effects from other uses of ItemListView?)
2. Ensure that the event handler is only subscribed once in the Experiment (e.g. unsubscribe before subscription or something like (1)).

(1) ​http://stackoverflow.com/questions/136975/has-an-event-handler-already-been-added

[swagner]

Fixed in r5928.

[mkommend]

Reviewed changeset r5928.