Opened 9 years ago

Closed 8 years ago

#1442 closed feature request (done)

Primitive type Tuple should be serializable

Reported by: mkommend Owned by: epitzer
Priority: high Milestone: HeuristicLab 3.3.4
Component: Persistence Version: 3.3.4
Keywords: Cc:

Description


Change History (8)

comment:1 Changed 9 years ago by epitzer

  • Status changed from new to accepted

comment:2 Changed 9 years ago by epitzer

Add a simple TupleSerializer for .NET 4.0 Tuple types. (r5698)

comment:3 Changed 9 years ago by epitzer

  • Owner changed from epitzer to mkommend
  • Status changed from accepted to reviewing

comment:4 Changed 9 years ago by mkommend

  • Status changed from reviewing to assigned

comment:5 Changed 9 years ago by mkommend

  • Owner changed from mkommend to epitzer
  • Status changed from assigned to reviewing

r5714: Corrected bug in TupleSerializer.

Used the generic type arguments of the Tuple instead of the dynamic value types to call the Tuple.Create method. This avoids co- / contravariance issues when dealing with collections of Tuples. I haven't adapted the unit tests for the tuple serializer and I am not sure which side effect this change has.

Erik, please review the changeset carefully.

Last edited 9 years ago by mkommend (previous) (diff)

comment:6 Changed 9 years ago by epitzer

  • Owner changed from epitzer to swagner

Thanks mkommend! I think your version makes much more sense. I just ran the tests again and everything works as expected.

comment:7 Changed 9 years ago by swagner

  • Owner changed from swagner to epitzer
  • Status changed from reviewing to readytorelease

comment:8 Changed 8 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.3 to 3.3.4
Note: See TracTickets for help on using tickets.