Opened 7 years ago

Closed 4 years ago

#1421 closed defect (done)

Change of StringValue in ItemCollection View does not react on Enter

Reported by: vdorfer Owned by: mkommend
Priority: medium Milestone: HeuristicLab 3.3.9
Component: Data.Views Version: 3.3.3
Keywords: Cc:

Description

Bug can be reproduced by:

  • Add a new StringValue to the ItemCollection
  • Change the Value of the StringValue
  • Press Enter

--> the change is not visible in the item list in the left window (see screenshot), only after changing the focus. This bug does NOT occur again when adding another StringValue.

Attachments (1)

ItemCollection.jpg (91.2 KB) - added by vdorfer 7 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by vdorfer

comment:1 follow-up: Changed 4 years ago by gkronber

I can reproduce this issue with HL 3.3.8.

Seemingly the ListView stores a column width that is not update when the underlying value is changed. That's why the string is cut off after a few pixels. The column width of the list view must be updated when one of the stored items is changed.

Pressing F2 to rename has nothing to do with it.

comment:2 Changed 4 years ago by gkronber

  • Priority changed from low to medium

comment:3 Changed 4 years ago by mkommend

  • Status changed from new to accepted

comment:4 in reply to: ↑ 1 Changed 4 years ago by mkommend

Replying to gkronber:

I can reproduce this issue with HL 3.3.8.

Seemingly the ListView stores a column width that is not update when the underlying value is changed. That's why the string is cut off after a few pixels. The column width of the list view must be updated when one of the stored items is changed.

Pressing F2 to rename has nothing to do with it.

Another possibility is to set the columns to autoresize depending on the contents and get rid of the questionable AdjustListViewColumnSizes method.

Unfortunately, there is not option for automatic resize of columns in a ListView. I thought this could be achieved by using the magic value -2 for the column width (cf. http://stackoverflow.com/questions/4802744/adjust-listview-columns-to-fit-with-winforms), but this, as the AdjustListViewColumnSizes, has to be triggered manually.

Last edited 4 years ago by mkommend (previous) (diff)

comment:5 Changed 4 years ago by mkommend

  • Milestone changed from HeuristicLab 3.3.x Backlog to HeuristicLab 3.3.9
  • Owner changed from mkommend to gkronber
  • Status changed from accepted to reviewing

r9755: Added calls to AdjustListViewColumnSizes when an item changes its ToString representation.

comment:6 Changed 4 years ago by gkronber

  • Owner changed from gkronber to mkommend
  • Status changed from reviewing to readytorelease

Reviewed r9755 and tested the changes. Works nicely. Thanks for fixing this!

comment:7 Changed 4 years ago by mkommend

  • Resolution set to done
  • Status changed from readytorelease to closed

r9814: Integrated r9755 into stable.

Note: See TracTickets for help on using tickets.