Opened 9 years ago

Closed 8 years ago

#1348 closed enhancement (done)

DefaultApplicationManager may crash in RegisterLoadedAssembly

Reported by: abeham Owned by: abeham
Priority: low Milestone: HeuristicLab 3.3.4
Component: PluginInfrastructure Version: 3.3.4
Keywords: Cc:

Description

I suspect this will happen only on development machines, but if you rename a plugin and forget to rename the assembly name, RegisterLoadedAssembly will throw an ArgumentException claiming (rightfully) that the same key has already been added to the dictionary.

I suggest catching an ArgumentException and rethrowing it with something more descriptive like: "An assembly with the same name was already loaded: " + asm.FullName

Change History (6)

comment:1 Changed 8 years ago by gkronber

  • Status changed from new to accepted

comment:2 Changed 8 years ago by gkronber

  • Milestone changed from HeuristicLab Backlog to HeuristicLab 3.3.4

comment:3 Changed 8 years ago by gkronber

r6021: added ContainsKey check and throw ArgumentException with a better error message.

comment:4 Changed 8 years ago by gkronber

  • Owner changed from gkronber to abeham
  • Status changed from accepted to reviewing

comment:5 Changed 8 years ago by abeham

  • Status changed from reviewing to readytorelease

great!

comment:6 Changed 8 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.2 to 3.3.4
Note: See TracTickets for help on using tickets.