Opened 11 years ago

Closed 10 years ago

#1155 closed enhancement (done)

Review and unify the readonly and locked state of views

Reported by: mkommend Owned by: mkommend
Priority: high Milestone: HeuristicLab 3.3.2
Component: General Version: 3.3.2
Keywords: Cc:

Description


Change History (26)

comment:1 Changed 11 years ago by mkommend

  • Status changed from new to accepted

comment:2 Changed 11 years ago by mkommend

Adjusted the SetEnabledStateOfControls method in all views, added the Enabled property into the IView interface and adapted the ViewHost, View and ContentView class with r4435.

comment:3 Changed 11 years ago by mkommend

  • Owner changed from mkommend to swagner
  • Status changed from accepted to reviewing

Changed the behavior and states of views. As this a major change in the MainForm class, the changes must be exhaustively tested.

comment:4 follow-ups: Changed 11 years ago by swagner

  • Owner changed from swagner to mkommend
  • Status changed from reviewing to assigned

Reviewed changes and encountered following issues:

  • Saving the clipboard is allowed, even if it contains a running algorithm. After the save operation is completed, the algorithm view is not enabled anymore.
  • Dropping values on a VariableValueView does not work anymore. However, the two methods valuePanel_DragEnterOver and valuePanel_DragDrop are still there.
  • If the content of a content view is null, the whole content view is disabled (see ContentView, line 112). I think this is a bit too much. Each content view should decide on its own which controls should be enabled or disabled, if there is no content (for example, even if the content is null, a user should be able to switch tabs).
  • View implements the Enabled property of IView explicitly. The code for suspending and resuming repaints is now located in this property. In the former solution View implemented the Enabled property using the new keyword. I think using the new keyword was the better solution. Now repaints will be suspended and resumed only if the Enabled property is set via the IView interface.
  • In the ViewHost the space between the viewsLabel and the content should be increased by a few pixels.
  • I think in line 170 of the OperatorGraphView (operator graph visualization) !Locked is not necessary.

comment:5 Changed 11 years ago by mkommend

  • Status changed from assigned to accepted

Registered drag events to enable drag and drop on VariableValueViews with r4445.

comment:6 Changed 11 years ago by mkommend

Removed the coupling of the Enabled property with Content != null with r4446.

comment:7 in reply to: ↑ 4 Changed 11 years ago by mkommend

Replying to swagner:

Reviewed changes and encountered following issues:

  • Saving the clipboard is allowed, even if it contains a running algorithm. After the save operation is completed, the algorithm view is not enabled anymore.

Corrected saving of items in the Clipboard with r4447.

comment:8 in reply to: ↑ 4 Changed 11 years ago by mkommend

Replying to swagner:

  • I think in line 170 of the OperatorGraphView (operator graph visualization) !Locked is not necessary.

Enabled breakpoints in the OperatorGraphView although it is locked with r4448.

comment:9 in reply to: ↑ 4 Changed 11 years ago by mkommend

Replying to swagner:

  • View implements the Enabled property of IView explicitly. The code for suspending and resuming repaints is now located in this property. In the former solution View implemented the Enabled property using the new keyword. I think using the new keyword was the better solution. Now repaints will be suspended and resumed only if the Enabled property is set via the IView interface.

Refactored View.Enabled to hide the Control.Enabled property and additionally implement IView.Enabled explicitly with r4449.

comment:10 Changed 11 years ago by mkommend

  • Owner changed from mkommend to swagner
  • Status changed from accepted to reviewing

Refactored the Clipboard to handle IExecuteables and repositioned the label in the ViewHost with r4453.

comment:11 Changed 11 years ago by mkommend

Forgot to update the caption of the ViewHost, when the active view is changed with r4465.

comment:12 follow-up: Changed 11 years ago by swagner

Reviewed changes and encountered following issues:

  • The ViewHost in the VariableValueView is always disabled.
  • Dropping values onto a VariableValueView does not work.
  • I would recommend a slightly different message in the clipboard, when not all items can be saved (changed in r4500).

comment:13 Changed 11 years ago by swagner

  • Owner changed from swagner to mkommend
  • Status changed from reviewing to assigned

comment:14 in reply to: ↑ 12 Changed 11 years ago by mkommend

Replying to swagner:

  • The ViewHost in the VariableValueView is always disabled.

I could not verify that the ViewHost is always disabled.

  • Dropping values onto a VariableValueView does not work.

Forgot to set AllowDrop to true for VariableValueView with r4509.

Last edited 11 years ago by mkommend (previous) (diff)

comment:15 Changed 11 years ago by mkommend

  • Status changed from assigned to accepted

comment:16 Changed 11 years ago by mkommend

  • Owner changed from mkommend to swagner
  • Status changed from accepted to reviewing

comment:17 Changed 11 years ago by swagner

  • Resolution set to done
  • Status changed from reviewing to closed
  • Version changed from 3.3.0 to 3.3.1

comment:18 Changed 11 years ago by swagner

  • Type changed from task to enhancement

comment:19 Changed 11 years ago by mkommend

  • Resolution done deleted
  • Status changed from closed to reopened

comment:20 Changed 11 years ago by mkommend

  • Owner changed from swagner to mkommend
  • Status changed from reopened to accepted

SetEnabledStateOfControls must be called after the changes of ReadOnly and Locked have been propagated to nested views. Otherwise it is not possible to change the properties for a nested view.

comment:21 Changed 11 years ago by mkommend

Called SetEnabledStateOfControls after the state changes have been propagated with r4519.

comment:22 Changed 11 years ago by mkommend

  • Status changed from accepted to reviewing

Enabled dropping of values on various views with r4522.

comment:23 Changed 11 years ago by mkommend

Corrected locked and readonly state in ExperimentView with r4526.

Last edited 11 years ago by swagner (previous) (diff)

comment:24 Changed 11 years ago by mkommend

  • Owner changed from mkommend to swagner

comment:25 Changed 11 years ago by swagner

  • Owner changed from swagner to mkommend
  • Status changed from reviewing to readytorelease

comment:26 Changed 10 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.1 to 3.3.2
Note: See TracTickets for help on using tickets.