Changeset 885 for branches/CloningRefactorBranch/HeuristicLab.Data/StringData.cs

Timestamp:

12/02/08 14:13:06 (16 years ago)

Author:

gkronber

Message:

Refactored cloning in HL.Core, HL.Data and HL.Constraints

#285 (Cloning could be improved by creating objects at the bottom of the cloning chain with 'new' instead of the top with Activator.CreateInstance())

File:

• branches/CloningRefactorBranch/HeuristicLab.Data/StringData.cs (modified) (2 diffs)

branches/CloningRefactorBranch/HeuristicLab.Data/StringData.cs

@@ -55 +55 @@
       Data = data;
     }
+
+    /// <summary>
+    /// Copy constructor to create clones (deep).
+    /// </summary>
+    /// <param name="original">The original instance to be cloned.</param>
+    public StringData(StringData original) : this(original, new Dictionary<Guid, object>()) { }
+   /// <summary>
+    /// Copy constructor to create clones (deep) reusing already cloned object references.
+    /// </summary>
+    /// <param name="original">The instance to be cloned.</param>
+    /// <param name="clonedObjects">Already cloned objects (for referential integrity).</param>
+    protected StringData(StringData original, IDictionary<Guid, object> clonedObjects)
+      : base(original, clonedObjects) {
+      this.Data = original.Data;
+    }
     
     /// <summary>
@@ -65 +80 @@
 
     /// <summary>
-    /// Clones the current instance.
+    /// Clones the current instance using the copy constructor.
     /// </summary>
     /// <remarks>The current instance is added to the dictionary <paramref name="clonedObjects"/>.</remarks>
-    /// <param name="clonedObjects">A dictionary of all already cloned objects.</param>
+    /// <param name="clonedObjects">A dictionary of all already cloned objects (for referential integrity).</param>
     /// <returns>The coned instance as <see cref="StringData"/>.</returns>
     public override object Clone(IDictionary<Guid, object> clonedObjects) {
-      StringData clone = new StringData();
-      clonedObjects.Add(Guid, clone);
-      clone.Data = Data;
-      return clone;
+      return new StringData(this, clonedObjects);
     }