Changeset 8086 for branches/ScatterSearch (trunk integration)/HeuristicLab.Problems.Knapsack/3.3/Improvers/KnapsackImprovementOperator.cs

Timestamp:

06/22/12 11:11:38 (12 years ago)

Author:

jkarder

Message:

#1331:

• synced branch with trunk
• added custom interface (ISimilarityBasedOperator) to mark operators that conduct similarity calculation
• similarity calculators are now parameterized by the algorithm
• deleted SolutionPool2TierUpdateMethod
• deleted KnapsackMultipleGuidesPathRelinker
• moved IImprovementOperator, IPathRelinker and ISimilarityCalculator to HeuristicLab.Optimization
• added parameter descriptions
• fixed plugin references
• fixed count of EvaluatedSolutions
• fixed check for duplicate solutions
• minor code improvements

Location:

branches/ScatterSearch (trunk integration)

Files:

• . (modified) (2 props)
• HeuristicLab.Problems.Knapsack/3.3/Improvers/KnapsackImprovementOperator.cs (modified) (7 diffs)

branches/ScatterSearch (trunk integration)

@@ -20 +20 @@
 bin
 protoc.exe
+_ReSharper.HeuristicLab 3.3 Tests

@@ -20 +20 @@
 bin
 protoc.exe
+_ReSharper.HeuristicLab 3.3 Tests

branches/ScatterSearch (trunk integration)/HeuristicLab.Problems.Knapsack/3.3/Improvers/KnapsackImprovementOperator.cs

@@ -20 +20 @@
 #endregion
 
+using System;
 using System.Linq;
 using HeuristicLab.Common;
@@ -26 +27 @@
 using HeuristicLab.Encodings.BinaryVectorEncoding;
 using HeuristicLab.Operators;
-using HeuristicLab.Optimization.Operators;
+using HeuristicLab.Optimization;
 using HeuristicLab.Parameters;
 using HeuristicLab.Persistence.Default.CompositeSerializers.Storable;
@@ -70 +71 @@
       set { PenaltyParameter.ActualValue = value; }
     }
-    private IItem Target {
-      get { return TargetParameter.ActualValue; }
-    }
     private IntArray Values {
       get { return ValuesParameter.ActualValue; }
@@ -89 +87 @@
       : base() {
       #region Create parameters
-      Parameters.Add(new ScopeParameter("CurrentScope"));
-      Parameters.Add(new LookupParameter<IntValue>("KnapsackCapacity"));
-      Parameters.Add(new LookupParameter<DoubleValue>("Penalty"));
-      Parameters.Add(new ValueLookupParameter<IItem>("Target"));
-      Parameters.Add(new LookupParameter<IntArray>("Values"));
-      Parameters.Add(new LookupParameter<IntArray>("Weights"));
+      Parameters.Add(new ScopeParameter("CurrentScope", "The current scope that contains the solution to be improved."));
+      Parameters.Add(new LookupParameter<IntValue>("KnapsackCapacity", "Capacity of the Knapsack."));
+      Parameters.Add(new LookupParameter<DoubleValue>("Penalty", "The penalty value for each unit of overweight."));
+      Parameters.Add(new ValueLookupParameter<IItem>("Target", "This parameter is used for name translation only."));
+      Parameters.Add(new LookupParameter<IntArray>("Values", "The values of the items."));
+      Parameters.Add(new LookupParameter<IntArray>("Weights", "The weights of the items."));
       #endregion
     }
@@ -104 +102 @@
     public override IOperation Apply() {
       BinaryVector sol = CurrentScope.Variables[TargetParameter.ActualName].Value as BinaryVector;
+      if (sol == null)
+        throw new ArgumentException("Cannot improve solution because it has the wrong type.");
 
       // calculate value-to-weight ratio
@@ -113 +113 @@
       // calculate order for ratio
       int[] order = new int[ratio.Length];
-      ratio.Select((x, index) => new { Value = x, ValueIndex = index })
-           .OrderBy(x => x.Value)
-           .Select((x, index) => new { ValueIndex = x.ValueIndex, ItemIndex = index }).ToList()
-           .ForEach(x => order[x.ItemIndex] = x.ValueIndex);
+      foreach (var x in ratio.Select((x, index) => new { Value = x, ValueIndex = index })
+                             .OrderBy(x => x.Value)
+                             .Select((x, index) => new { ValueIndex = x.ValueIndex, ItemIndex = index })) {
+        order[x.ItemIndex] = x.ValueIndex;
+      }
 
+      int evaluatedSolutions = 0;
       int j = sol.Length - 1;
       while (KnapsackEvaluator.Apply(sol, KnapsackCapacity, Penalty, Weights, Values)
-                              .SumWeights.Value > KnapsackCapacity.Value && j >= 0)
+                              .SumWeights.Value > KnapsackCapacity.Value && j >= 0) {
         sol[order[j--]] = false;
+        evaluatedSolutions++;
+      }
 
       // calculate weight
@@ -136 +140 @@
           weight += Weights[order[j]];
         } else feasible = false;
+        evaluatedSolutions++;
       }
 
       CurrentScope.Variables[TargetParameter.ActualName].Value = sol;
+      CurrentScope.Variables.Add(new Variable("LocalEvaluatedSolutions", new IntValue(evaluatedSolutions)));
 
       return base.Apply();

@@ -20 +20 @@
 bin
 protoc.exe
+_ReSharper.HeuristicLab 3.3 Tests